-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Talawa to give a meaningful message if the URL isn't available. #1378
Comments
Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues. |
@palisadoes please assign it to me, I'll complete this issue |
talawa/lib/widgets/organization_list.dart Lines 34 to 51 in 46cf4ef
I went through the code and I think issue exists here. If we set |
…age if the URL isn't available.
Hi, @palisadoes I implemented the solution, can you review it?? |
…age if the URL isn't available.
@Ayush0Chaudhary Please open a pull request against this repo |
I opened the PR against this issue but later was asked to change the PR title |
Here is the link to PR @palisadoes |
…'t available. (#1380) * feat: Add proper error handling if url not available. * Fix #1378 Update Talawa to give a meaningful message if the URL isn't available. * fixes the failed checks. * Make the suggested changes * Add error widget * Add custom error snackbar for Talawa * Make the notif bar scrollable. * Remove the useless part * Add dialog box with scroll instead of snackbar * added the custom widget * added the custom widget * Completed the request changes. * removed all the warnings * changed the app-setting test * Add test for custom error widget and did err-handling in qrScan * removed all warnings * Update build.gradle * Delete google-services.json * Update build.gradle * Delete GoogleService-Info.plist * Delete firebase_app_id_file.json
Is your feature request related to a problem? Please describe.
When I started the app and followed the setup documentation I ran into this problem, Only got to know about it after I checked out community slack
Describe the solution you'd like
Give proper error messages when URl isn't available
Describe alternatives you've considered
Give error message
The text was updated successfully, but these errors were encountered: