Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Talawa to give a meaningful message if the URL isn't available. #1378

Closed
Ayush0Chaudhary opened this issue Dec 30, 2022 · 7 comments · Fixed by #1380
Closed

Update Talawa to give a meaningful message if the URL isn't available. #1378

Ayush0Chaudhary opened this issue Dec 30, 2022 · 7 comments · Fixed by #1380
Assignees
Labels

Comments

@Ayush0Chaudhary
Copy link

Is your feature request related to a problem? Please describe.
When I started the app and followed the setup documentation I ran into this problem, Only got to know about it after I checked out community slack

Describe the solution you'd like
Give proper error messages when URl isn't available

Describe alternatives you've considered
Give error message

@github-actions
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@github-actions github-actions bot added documentation Update documentation unapproved Unapproved, needs to be triaged labels Dec 30, 2022
@Ayush0Chaudhary
Copy link
Author

@palisadoes please assign it to me, I'll complete this issue

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Dec 30, 2022
@Ayush0Chaudhary
Copy link
Author

if (result.hasException) {
final isException = databaseFunctions.encounteredExceptionOrError(
result.exception!,
showSnackBar: false,
);
if (isException != null) {
if (isException) {
refetch!();
} else {
refetch!();
}
}
} else {
if (!result.isLoading) {
model.organizations = OrgInfo().fromJsonToList(
result.data!['organizationsConnection'] as List,
);
}

I went through the code and I think issue exists here.

If we set showSnackBar = true
the code will try to show SnackBar while building the screen, thus throwing a error.
Am I going in right direction @palisadoes @SiddheshKukade ??

Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Dec 30, 2022
@Ayush0Chaudhary
Copy link
Author

Hi, @palisadoes I implemented the solution, can you review it??
Please suggest changes if any required...
Ayush0Chaudhary@c22d593

@palisadoes
Copy link
Contributor

@Ayush0Chaudhary Please open a pull request against this repo

@Ayush0Chaudhary
Copy link
Author

I opened the PR against this issue but later was asked to change the PR title
@palisadoes

@Ayush0Chaudhary
Copy link
Author

#1380

Here is the link to PR @palisadoes

palisadoes pushed a commit that referenced this issue Jan 27, 2023
…'t available. (#1380)

* feat: Add proper error handling if url not available.

* Fix #1378 Update Talawa to give a meaningful message if the URL isn't available.

* fixes the failed checks.

* Make the suggested changes

* Add error widget

* Add custom error snackbar for Talawa

* Make the notif bar scrollable.

* Remove the useless part

* Add dialog box with scroll instead of snackbar

* added the custom widget

* added the custom widget

* Completed the request changes.

* removed all the warnings

* changed the app-setting test

* Add test for custom error widget and did err-handling in qrScan

* removed all warnings

* Update build.gradle

* Delete google-services.json

* Update build.gradle

* Delete GoogleService-Info.plist

* Delete firebase_app_id_file.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants