Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize TalawaErrorWidget Throughout App #1437

Closed
palisadoes opened this issue Jan 27, 2023 · 13 comments · Fixed by #1562
Closed

Utilize TalawaErrorWidget Throughout App #1437

palisadoes opened this issue Jan 27, 2023 · 13 comments · Fixed by #1562
Assignees

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 27, 2023

  1. We do not have a standardized error reporting scheme
  2. We recently created TalawaErrorWidget for handling errors. We need use it for all our error messages.

Ideally there should be ways to adjust the output depending on the error severity for example:

  1. Warning
  2. Info
  3. Error

Additionally:

  1. The error messaging must also adjust any text to match the user's selected language of choice
  2. The methodology must output messages to the console for ease of troubleshooting
@palisadoes palisadoes added bug Something isn't working feature request labels Jan 27, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Jan 27, 2023
@prathamesh-mutkure
Copy link

Hello @palisadoes, I'd like to work on this issue

@palisadoes palisadoes removed the bug Something isn't working label Jan 27, 2023
@palisadoes palisadoes assigned palisadoes and unassigned palisadoes Jan 27, 2023
@palisadoes
Copy link
Contributor Author

  1. We are focusing on bugs and testing issues.
  2. When we get back to working on features we'll need to discuss a design for the messages. The existing widget may not meet the needs of all use cases and will have to be adjusted accordingly, or new widgets may need to be created.

@prathamesh-mutkure
Copy link

Okay, so we are not working on this issue for a while, right?

@palisadoes
Copy link
Contributor Author

Correct

@shivanshu814
Copy link

I want to contribute to this repository and want to get involved in GSoC discussions.

@palisadoes palisadoes self-assigned this Jan 29, 2023
@github-actions
Copy link

This issue did not get any activity in the past 14 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@Ayush0Chaudhary
Copy link

Ayush0Chaudhary commented Feb 14, 2023

Yes, we can create something like this for showing errors, info, warning.

We can tweak part of the dialog to show different dialog for warning, info, and errors.

For this we can add argument in TalawaErrorWidget for ex.
navigationService.showTalawaErrorDialog("Enter a validpassword", type: ErrorType.warning);

here ErrorType can be a enum like
enum ErrorType { error, warning, info }

We should definitely add multi language functionality,
It will be good idea if we add debugPrint statement for these method so in future it will be easier to debug

@palisadoes @noman2002 @SiddheshKukade @TheHazeEffect

@Ayush0Chaudhary
Copy link

Can I work on this?? @noman2002 @TheHazeEffect

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 14, 2023
@Ayush0Chaudhary
Copy link

Screenshot from 2023-02-16 00-03-46

@palisadoes @noman2002 what about these pop up, should I make something like these??

@palisadoes
Copy link
Contributor Author

Yes and also consider how they would work if there is so much text that it scrolls off the screen

@Ayush0Chaudhary
Copy link

ok @palisadoes i'll keep that in mind.

@palisadoes
Copy link
Contributor Author

Also ensure that the errors support multilingual needs.

@Ayush0Chaudhary
Copy link

Sure

Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Feb 24, 2023
palisadoes pushed a commit that referenced this issue Feb 24, 2023
* Fixes #1483 showSnackBar error: showing snackbar before screen is built

* Make the Dialog box functionable

* Fixes #1437 Utilize TalawaErrorWidget Throughout App

* Added test for the same

* Resolved the conflicts and changed the mocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants