Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump build_runner from 2.1.10 to 2.3.3 #1493

Closed
palisadoes opened this issue Feb 14, 2023 · 4 comments · Fixed by #1510
Closed

Bump build_runner from 2.1.10 to 2.3.3 #1493

palisadoes opened this issue Feb 14, 2023 · 4 comments · Fixed by #1510
Assignees
@literalEval
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security fix

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 14, 2023 •
edited

Bump build_runner from 2.1.10 to 2.3.3

We need to do this upgrade to improve the performance, reliability and security of the code base.

  1. This upgrade will require you to fix other dependencies. You can verify this with the command flutter pub get
  2. All tests will need to pass after this is completed
  3. All existing functionality will need be maintained after this is completed

This is tied to PR #1492
Your PR will need to be merged beforehand so that we can successfully close the one mentioned previously
@palisadoes palisadoes added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 14, 2023
@github-actions github-actions bot added security Security fix unapproved Unapproved, needs to be triaged labels Feb 14, 2023
@palisadoes palisadoes mentioned this issue Feb 14, 2023
Closed
@literalEval
Copy link
Member

Does this issue need work ? If yes, then please assign this to me.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 16, 2023
Ghazali32 added a commit to Ghazali32/talawa that referenced this issue Feb 17, 2023
@Ghazali32
PalisadoesFoundation#1493 Changed lint from 1.6.0 to 2.0.1
8759a2e 
 Changed lint from 1.6.0 to 2.0.1
upgraded required dependencies and verified with "flutter pub get" command.
@literalEval
Copy link
Member

@palisadoes this bump requires higher SDK version.

@palisadoes
Copy link
Contributor Author

What SDK version would you recommend. I think we are using Java v12 which is not a long term support version. In fact it may soon be deprecated from GitHub actions.

@literalEval
Copy link
Member

Hmm. Flutter latest version from the stable channel is what I am upgrading to for now. If flutter upgrade gets merged without issues, then we will discuss for Java etc. Till then, I will also research on what others are using and what's better.

@literalEval literalEval mentioned this issue Feb 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@literalEval literalEval

Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump sdk in workflow literalEval/talawa
2 participants
@palisadoes @literalEval