Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for lib/utils/chat_queries.dart #1515

Closed
palisadoes opened this issue Feb 18, 2023 · 1 comment · Fixed by #1553
Closed

Tests for lib/utils/chat_queries.dart #1515

palisadoes opened this issue Feb 18, 2023 · 1 comment · Fixed by #1553
Assignees
@Ayush0Chaudhary
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 18, 2023 •
edited

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/utils/chat_queries.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • Our test/ folder has the same structure as the lib folder. Place your test file in the equivalent folder under test/. You may need to create the appropriate directory structure to do this.
  • Current test code coverage for this file can be found here

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Feb 18, 2023
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Feb 18, 2023
@palisadoes palisadoes added points 01 good first issue Good for newcomers and removed parent The issue is generating more sub-issues bug Something isn't working labels Feb 18, 2023
@Ayush0Chaudhary
Copy link

@palisadoes @noman2002 @xoldyckk @TheHazeEffect can i work on this??, I made my PR for 1 #1529, waiting to be merged.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 21, 2023
Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Feb 21, 2023
@Ayush0Chaudhary
Fixes PalisadoesFoundation#1515 Tests for lib/utils/chat_queries.dart
7cb0bb3
Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Feb 21, 2023
@Ayush0Chaudhary
Fixes PalisadoesFoundation#1515 Tests for lib/utils/chat_queries.dart
b9c7059
@Ayush0Chaudhary Ayush0Chaudhary mentioned this issue Feb 21, 2023
Merged
Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Feb 21, 2023
@Ayush0Chaudhary
Fixes PalisadoesFoundation#1515 Tests for lib/utils/chat_queries.dart
ff8b587
palisadoes pushed a commit that referenced this issue Feb 21, 2023
@Ayush0Chaudhary
Fixes #1515 Tests for lib/utils/chat_queries.dart (#1553)
2c4bc43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ayush0Chaudhary Ayush0Chaudhary

Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1515 Tests for lib/utils/chat_queries.dart Ayush0Chaudhary/talawa
2 participants
@palisadoes @Ayush0Chaudhary