Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Project to support java 17 #1542

Closed
TheHazeEffect opened this issue Feb 19, 2023 · 22 comments
Closed

Upgrade Project to support java 17 #1542

TheHazeEffect opened this issue Feb 19, 2023 · 22 comments
Assignees
Labels
dependencies Pull requests that update a dependency file feature request security Security fix

Comments

@TheHazeEffect
Copy link
Contributor

TheHazeEffect commented Feb 19, 2023

Is your feature request related to a problem? Please describe.
Talawa currently uses Java version 8, which although benefits from extended support, will eventually approach the end of it's long term support cycle.

Describe the solution you'd like
We would like to upgrade the Java version used in Talawa to the latest LTS(Long term support) version, which is Java 17. This will bring performance and security improvements to the project and ensures that it remains compatible with the latest Java features.

Describe alternatives you've considered
We have considered sticking with Java 8, but this becomes less ideal as we move closer to end of support. As an Open Source project, we would like to ensure due diligence in exercising that we do not leave potential security and performance improvements that would benefit the community behind.

Approach to be followed (optional)
The following steps will be followed to upgrade the Java version:

  • Update the build.gradle file to use the latest version of Gradle that supports Java 17.
  • Update any dependencies that may not be compatible with Java 17.
  • Ensure the app properly builds and runs for Android
  • Ensure the Pipeline is still able to build the project

Additional context
N/A

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@github-actions
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file security Security fix unapproved Unapproved, needs to be triaged labels Feb 19, 2023
@literalEval
Copy link
Member

@TheHazeEffect please assign this to me. I will do it as a part of post-sdk-migration.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 20, 2023
@gvjkumar2004
Copy link

Hi There, I am familiar with this, Can I go work on it ?

@palisadoes
Copy link
Contributor

It's already assigned

@noman2002
Copy link
Member

@literalEval Unassigning you because you have two other big issues in your name.

@noman2002
Copy link
Member

@gvjkumar2004 You can work on this.

@noman2002
Copy link
Member

@gvjkumar2004 Any update?

@gvjkumar2004
Copy link

gvjkumar2004 commented Feb 28, 2023 via email

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 11, 2023
@palisadoes
Copy link
Contributor

@gvjkumar2004 What progress have you made? We'd like to get this done, and possibly give someone else a chance if you are unable for any reason.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 12, 2023
@Ayush0Chaudhary
Copy link

@palisadoes @noman2002 can I work on this? if @gvjkumar2004 is not working on it anymore

@Ayush0Chaudhary
Copy link

@TheHazeEffect @palisadoes @noman2002 @literalEval we use currently gradle 7.0.2 which according to this answer uses Java 16

@Ayush0Chaudhary
Copy link

Is this an issue as new flutter project are also made on gradle 7.0.2 ?

@Ayush0Chaudhary
Copy link

Am I getting it wrong? Do correct me if so.

@literalEval
Copy link
Member

Yep @Ayush0Chaudhary we will need to upgrade Gradle, Java and other stuff altogether as they won't work if their versions don't match. Like a few years back, Flutter only supported Java 11, in spite of release of other Java updates. I still use OpenJDK 11.x.x in my machine. So please also look into whether Flutter now supports newer versions or not.

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 31, 2023
@palisadoes
Copy link
Contributor

Unassigning due to inactivity and no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@Ayush0Chaudhary
Copy link

Hi @palisadoes
I researched this issue.
The current gradle v supports Java 16. It is compatible with gradle, latest flutter v support. Nothing was failing once I upgraded the version.

@TheHazeEffect

@palisadoes
Copy link
Contributor

@Ayush0Chaudhary Please submit a PR

@literalEval
Copy link
Member

@Ayush0Chaudhary were you able to do a clean build after the migration ?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 1, 2023
@Ayush0Chaudhary
Copy link

@Ayush0Chaudhary were you able to do a clean build after the migration ?

Yes changed the java version on my machine and everything was working. There is no need of PR in this issue.

@TheHazeEffect your views?

@palisadoes

@palisadoes
Copy link
Contributor

OK, I'll close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature request security Security fix
Projects
None yet
Development

No branches or pull requests

6 participants