Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Mockito package to the latest version #1548

Closed
palisadoes opened this issue Feb 20, 2023 · 13 comments · Fixed by #1707
Closed

Upgrade the Mockito package to the latest version #1548

palisadoes opened this issue Feb 20, 2023 · 13 comments · Fixed by #1707
Assignees
Labels
bug Something isn't working test Testing application unapproved Unapproved, needs to be triaged

Comments

@palisadoes
Copy link
Contributor

Describe the bug

returnNullOnMissingStub is now deprecated in Mockito and needs to be migrated to their latest API.

Mitigation Process

  • Remove // ignore: .... from the top of test/helpers/test_helpers.dart
  • Fix all the lint warnings by migrating returnNullOnMissingStub to its latest alternative.
@palisadoes palisadoes added the bug Something isn't working label Feb 20, 2023
@github-actions github-actions bot added test Testing application unapproved Unapproved, needs to be triaged labels Feb 20, 2023
@gvjkumar2004
Copy link

Hii Palisadoes, I wanna work on this, can u assign this to me !

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 22, 2023
@literalEval
Copy link
Member

@gvjkumar2004 can you please tag me when you open the respective PR for this issue ?

@gvjkumar2004
Copy link

gvjkumar2004 commented Feb 24, 2023 via email

@literalEval
Copy link
Member

Thanks

@gvjkumar2004
Copy link

can anyone help me on this part of the process:
"Fix all the lint warnings by migrating returnNullOnMissingStub to its latest alternative."
I am done with the first one....

@palisadoes
Copy link
Contributor Author

The lint warnings tell you what you should do.

@literalEval
Copy link
Member

@gvjkumar2004 search for that deprecation. It will lead you to their documentation that tells you what are the latest alternatives to the deprecation. And then you will need to migrate accordingly. Hope this helps.

@palisadoes
Copy link
Contributor Author

@gvjkumar2004 Are you still working on this?

@noman2002
Copy link
Member

Unassigning due to inactivity.

@noman2002 noman2002 added the unapproved Unapproved, needs to be triaged label Mar 14, 2023
@gvjkumar2004
Copy link

gvjkumar2004 commented Mar 16, 2023 via email

@ALIRAZA17
Copy link

@noman2002 Can you assign me this issue please if noone is doing it?

@ALIRAZA17
Copy link

@palisadoes I have created a pull request related to this issue #1704 Can you check it out?

@ALIRAZA17
Copy link

@palisadoes I have created another PR #1707 for this issue because the other one became too messy Can you look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Testing application unapproved Unapproved, needs to be triaged
Projects
None yet
5 participants