Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Messaging When No Organizations are Created #1612

Closed
palisadoes opened this issue Mar 5, 2023 · 20 comments · Fixed by #1706 or #1782
Closed

No Messaging When No Organizations are Created #1612

palisadoes opened this issue Mar 5, 2023 · 20 comments · Fixed by #1706 or #1782
Assignees
Labels
bug Something isn't working good first issue Good for newcomers no-issue-activity No issue activity

Comments

@palisadoes
Copy link
Contributor

Describe the bug

  1. When no organizations are created, Talawa presents an empty screen in the select organization screen.
  2. No information is provided as to how the user must proceed.

To Reproduce
Steps to reproduce the behavior:

  1. Install Talawa, Talawa-API and Talawa-Admin as per their installation guides
  2. When you try to select an organization in Talawa, you get no error message about why none are being displayed.

Expected behavior
We need a popup message that states "No organizations found Please create one using Talawa Admin"."

Actual behavior
See above

Screenshots
image

Additional details
See above

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers points 02 labels Mar 5, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 5, 2023
@indresh149
Copy link

may I work on this issue?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 5, 2023
@palisadoes
Copy link
Contributor Author

@indresh149

  1. It also doesn't make sense to have a Continue button. It should say Back or something similar
  2. Make sure your message automatically changes depending on the language. This may require you to add some entries in the Talawa-API translations. Try searching closed PRs to see how this is done.

@indresh149
Copy link

indresh149 commented Mar 5, 2023

@palisadoes ok sure I will try to fix this I also think there should be a Back button instead of continue. Thank you

@aryamanshrivastava
Copy link

aryamanshrivastava commented Mar 5, 2023

@palisadoes Could you kindly grant me permission to work on this issue?

@palisadoes
Copy link
Contributor Author

@aryamanshrivastava is already been assigned. Please look at other issues in the queue.

  1. There are many test case issues
  2. Look for bugs that have a serious impact on the operation of the app and create issues for it. This issue was created after a bug was found

@indresh149
Copy link

which snackbar i will use for showing this message (No organization exist please create one) ?

image

or

image

@palisadoes

@palisadoes
Copy link
Contributor Author

The first one. However make the message tell the user that they should contact the Organization Administrator

@indresh149
Copy link

@palisadoes ok. Thank you

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 18, 2023
@SiddheshKukade
Copy link
Member

@palisadoes Sir I would like to work on this issue? I can display the "No organizations found Please create one using Talawa Admin / contact your admin" mesaage and I will also convert the continue button to back button if no issues are found.
Please assign, thanks.

@palisadoes
Copy link
Contributor Author

palisadoes commented Mar 19, 2023

Reassigning due to lack of activity. @SiddheshKukade please go ahead

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 20, 2023
palisadoes pushed a commit that referenced this issue Mar 24, 2023
…mentation for `select_organization.dart`, `organization_list.dart` closes #1612 (#1706)

* feat:  changed button text based on org list length

* feat: add error dialog for org list page.

* feat(docs) : added comment and removed ignore statements

* feat(docs): add comments for `model` variable

* feat(docs) : add comments for `select_organization.dart`

* fix: ci/cd errors.
@Ayush0Chaudhary
Copy link

Instead of calling it after adding frame, we should add a timer of like 5 seconds.
If the orgs are not fetched by then. then we should show this error widget

@Ayush0Chaudhary
Copy link

@palisadoes I can fix this as i have already corrected it on my local.

@SiddheshKukade
Copy link
Member

@Ayush0Chaudhary the solution was working fine for me. Make sure you're using all of the updated versions of API.

@Ayush0Chaudhary
Copy link

@SiddheshKukade please have a look at the code.

// If the result is still loading!
if (!result.isLoading) {
model.organizations = OrgInfo().fromJsonToList(
result.data!['organizationsConnection'] as List,
);
}
WidgetsBinding.instance.addPostFrameCallback((_) {
if (model.organizations.isEmpty) {
navigationServiceLocal.showTalawaErrorDialog(
"No organizations found Please contact your admin",
MessageType.error,
);
}
});

@Ayush0Chaudhary the solution was working fine for me. Make sure you're using all of the updated versions of API.

I checked it, I have the latest version.

PS: My intentions were not to offend you. ✌️

@Ayush0Chaudhary
Copy link

Screenshot from 2023-04-14 12-38-06
@palisadoes @SiddheshKukade
The current implementation is not considering the multiple refetch of the orglist.

Should we reopen this issue?

@SiddheshKukade
Copy link
Member

PS: My intentions were not to offend you. ✌️

@Ayush0Chaudhary

I'm not offended at all. I was just confused about why was that code working for me. (you can also refer to the screenshots of the past PRs )

@Ayush0Chaudhary
Copy link

PS: My intentions were not to offend you. v

@Ayush0Chaudhary

I'm not offended at all. I was just confused about why was that code working for me. (you can also refer to the screenshots of the past PRs )

The code was failing because it checks whether the data has arrived as soon as the widget are rendered. And in real world there is a lot of latency.
@SiddheshKukade

@SiddheshKukade
Copy link
Member

@Ayush0Chaudhary I actually tested on the real device, and I think you're testing it on emulator r. That's why there might be some latency.

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 27, 2023
palisadoes pushed a commit that referenced this issue Jul 19, 2023
* Fixes #1612 No Messaging When No Organizations are Created

* Add constant time-out for loading data.

* Add constant time-out for loading data.

* Fixed the failing test

* Fixed the failing test

* Removed the unsed imports.

* modified test

* formating
palisadoes pushed a commit to palisadoes/talawa that referenced this issue Jan 10, 2024
…#1891)

* Fixes PalisadoesFoundation#1612 No Messaging When No Organizations are Created

* Add constant time-out for loading data.

* Add constant time-out for loading data.

* chore: Add request-screen-1 with optional message.

* formatting

* feat: Added final UI comp, according to the design.

* chore: Added dart formatting

* chore: remove darker shade from app bar

* feat: Add viewmodel logic for waiting screen.

* Chore: redeisgn the select organization screen.

* formatting

* Draft Commit

* Merged All the flow of new Member Management.

* Fixed the failing test

* Fixed the failing test

* Removed the unsed imports.

* Fixed the formating

* Some last changes

* formatting

* formatting

* formatting

* added documentation

* added documentation

* added documentation

* wrote test for set_url, custon tile, select org, according to the new UI

* draft

* Add the test for select org VM and join org after auth screen according to the new implementation.

* formatting

* formatting
palisadoes pushed a commit to palisadoes/talawa that referenced this issue Jan 10, 2024
…e Created (PalisadoesFoundation#1782)

* Fixes PalisadoesFoundation#1612 No Messaging When No Organizations are Created

* Add constant time-out for loading data.

* Add constant time-out for loading data.

* Fixed the failing test

* Fixed the failing test

* Removed the unsed imports.

* modified test

* formating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment