Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Non Removable Activity Loader #1618

Closed
Ayush0Chaudhary opened this issue Mar 5, 2023 · 2 comments · Fixed by #1628
Closed

Bug: Non Removable Activity Loader #1618

Ayush0Chaudhary opened this issue Mar 5, 2023 · 2 comments · Fixed by #1628
Assignees
@Ayush0Chaudhary
Labels
bug Something isn't working

Comments

@Ayush0Chaudhary
Copy link

Describe the bug
Even when there is error, the activity loader keeps on loading and blocks the screen
To Reproduce
Steps to reproduce the behavior:

1.Enter a wrong Url in join org

Expected behavior
My screen got blocked.

Actual behavior
Activity loader should be removed when the moment we click somewhere else

ScreenVideo

te.mp4

Additional details
It works for mobile phone with inbuilt reverse button, but not for every device,
it will also fail for ios devices

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359
@Ayush0Chaudhary Ayush0Chaudhary added the bug Something isn't working label Mar 5, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 5, 2023
@Ayush0Chaudhary
Copy link
Author

@palisadoes @noman2002 can i work on this?

@Ayush0Chaudhary Ayush0Chaudhary changed the title No removable Activity Loader Non removable Activity Loader Mar 5, 2023
@Ayush0Chaudhary Ayush0Chaudhary changed the title Non removable Activity Loader Bug: Non Removable Activity Loader Mar 5, 2023
@Ayush0Chaudhary
Copy link
Author

Also maybe have a new activity loader

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Mar 5, 2023
Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 6, 2023
@Ayush0Chaudhary
Fixes PalisadoesFoundation#1618 Bug: Non Removable Activity Loader
106e16a
@Ayush0Chaudhary Ayush0Chaudhary mentioned this issue Mar 6, 2023
Merged
palisadoes pushed a commit that referenced this issue Mar 7, 2023
@Ayush0Chaudhary
Fixes #1618 Bug: Non Removable Activity Loader (#1628)
6211a88 
* Fixes #1618 Bug: Non Removable Activity Loader

* removed linting errors
ikjot-2605 pushed a commit to ikjot-2605/talawa that referenced this issue Mar 8, 2023
@Ayush0Chaudhary @ikjot-2605
Fixes PalisadoesFoundation#1618 Bug: Non Removable Activity Loader (P…
ab601d7 
…alisadoesFoundation#1628)

* Fixes PalisadoesFoundation#1618 Bug: Non Removable Activity Loader

* removed linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ayush0Chaudhary Ayush0Chaudhary

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1618 Bug: Non Removable Activity Loader Ayush0Chaudhary/talawa
2 participants
@Cioppolo14 @Ayush0Chaudhary