Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make organization_list.dart multilingual #1710

Closed
palisadoes opened this issue Mar 24, 2023 · 1 comment · Fixed by #1722
Closed

Make organization_list.dart multilingual #1710

palisadoes opened this issue Mar 24, 2023 · 1 comment · Fixed by #1722
Assignees
Labels
bug Something isn't working test Testing application

Comments

@palisadoes
Copy link
Contributor

Describe the bug

  1. We need to make the error message displayed in lib/widgets/organization_list.dart multilingual to support our internationalization efforts.
  2. We should remove unnecessary print statements in the file
  3. We should also make sure that the test coverage for the file gets as close to 100% as possible

To Reproduce

The most obvious section of the code can be found here:

            print("is empyt or nt");
              print(model.organizations.isEmpty);
              if (model.organizations.isEmpty) {
                navigationServiceLocal.showTalawaErrorDialog(
                  "No organizations found ! Please contact your admin ",
                  MessageType.error,
                );
              }
            });

Expected behavior

See above

Actual behavior

See above

Screenshots

N/A

Additional details

N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@palisadoes palisadoes added the bug Something isn't working label Mar 24, 2023
@github-actions github-actions bot added test Testing application unapproved Unapproved, needs to be triaged labels Mar 24, 2023
@SiddheshKukade
Copy link
Member

SiddheshKukade commented Mar 25, 2023

I'd to get assigned to add multiple languages responses in all these files for the above statement :
image

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 25, 2023
palisadoes pushed a commit that referenced this issue Mar 27, 2023
)

* chores: Manual Bump geocoding to 2.1.0 closes #1711

* fix: removed print statements

* feat(docs): add translation for all the languages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants