Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement for the password strength bar #210

Closed
Raunakk02 opened this issue Mar 14, 2021 · 5 comments · Fixed by #211
Closed

Enhancement for the password strength bar #210

Raunakk02 opened this issue Mar 14, 2021 · 5 comments · Fixed by #211
Labels
unapproved Unapproved, needs to be triaged

Comments

@Raunakk02
Copy link
Contributor

Raunakk02 commented Mar 14, 2021 •
edited

Currently, the password strength bar is visible to the user even when the password text field is empty.
Also, the password strength bar updates only after the TextFormField is saved.

Enhancement:

  1. The password strength bar should only be visible if the password text field is not empty.

  2. The password strength bar should update when the content in the TextFormField changes.
@yasharth291
Copy link
Contributor

nice we can work on it if you want.

@Raunakk02
Copy link
Contributor Author

I enhanced it and am submitting the pull request. Please check if it's working fine or not.

@Raunakk02 Raunakk02 mentioned this issue Mar 14, 2021
Merged
@yasharth291
Copy link
Contributor

yeah no problem if it is working. it will be nice well done brother

@yasharth291
Copy link
Contributor

one thing that you can do is attaching this issue with the pr @Raunakk02

@Raunakk02
Copy link
Contributor Author

one thing that you can do is attaching this issue with the pr @Raunakk02

Thanks for the suggestion @yasharth291, but I already linked this issue to the PR.

@Raunakk02 Raunakk02 mentioned this issue Mar 14, 2021
Closed
@jordanliu jordanliu added the unapproved Unapproved, needs to be triaged label Mar 17, 2021
This was referenced Mar 18, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unapproved Unapproved, needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement for password strength bar Raunakk02/talawa
3 participants
@jordanliu @yasharth291 @Raunakk02