Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception toast in register form screen has overflow errors. #227

Closed
SriramPatibanda opened this issue Mar 14, 2021 · 6 comments · Fixed by #232
Closed

Exception toast in register form screen has overflow errors. #227

SriramPatibanda opened this issue Mar 14, 2021 · 6 comments · Fixed by #232
Assignees
@SriramPatibanda
Labels
unapproved Unapproved, needs to be triaged

Comments

@SriramPatibanda
Copy link
Contributor

Problem

The exception toast in the register form has overflow errors.

WhatsApp Image 2021-03-14 at 2 36 48 PM

Possible solution

Wrapping the Text widget with an Expanded widget would solve the problem.
@SriramPatibanda
Copy link
Contributor Author

@jordanliu Please assign this issue to me, I would like to work on it.

@Sagar2366
Copy link
Contributor

Sagar2366 commented Mar 14, 2021 •
edited

@SriramPatibanda, you are more than welcome to contribute to this project. If this is not duplicate issue, you can start working on this issue and share pr for review. Checkout latest master code and see if you are seeing this issue.

@adithyaakrishna
Copy link
Contributor

I guess this is not an Issue, @SriramPatibanda be sure to pull all the changes from the upstream/master to your repo and also set the Org. URL to http://calico.palisadoes.org/talawa/graphql

@SriramPatibanda SriramPatibanda mentioned this issue Mar 14, 2021
Merged
@Sagar2366
Copy link
Contributor

@SriramPatibanda, please share the steps to reproduce this issue. Are you on master branch ? Recently major fix has been added and these issues are already fixed. Please let us know if you still seeing this issue.

@SriramPatibanda
Copy link
Contributor Author

Closing this issue as it has already been fixed.

@SriramPatibanda
Copy link
Contributor Author

The Issue has been reopened as it persists in the app.

The steps to reproduce this issue have been mentioned in the pull request: #232

@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SriramPatibanda SriramPatibanda

Labels
unapproved Unapproved, needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solves Exception toast overflow on register form screen SriramPatibanda/talawa
4 participants
@palisadoes @adithyaakrishna @Sagar2366 @SriramPatibanda