Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Remove Support for Private Organizations #2287

Closed
palisadoes opened this issue Dec 30, 2023 · 17 comments · Fixed by #2322
Closed

Mobile - Remove Support for Private Organizations #2287

palisadoes opened this issue Dec 30, 2023 · 17 comments · Fixed by #2322
Assignees

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 30, 2023

Is your feature request related to a problem? Please describe.
We need to reduce and simplify some of the Talawa features.

The concept of private organizations is unlikely given that most organizations using Talawa will be non-profits where transparency will be important.

Describe the solution you'd like

Remove all support for private organizations in:

  1. Screens, sections of screens and supporting code that reference the feature

Other:

  1. All tests must be valid and pass
  2. No other functionality must be affected.

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context
Related issues include:

  1. API - Remove Support for Private Organizations talawa-api#1604
  2. Admin - Remove Support for Private Organizations talawa-admin#1327
  3. Mobile - Remove Support for Private Organizations #2287

Potential internship candidates

@Azad99-9
Copy link

@noman2002 @Cioppolo14 @Kevoniat can any one of you please assign this issue to me. I would like to work on this.

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Dec 31, 2023
@AVtheking
Copy link

Can I work on this issue?

@Cioppolo14
Copy link

@AVtheking If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@Azad99-9
Copy link

Azad99-9 commented Jan 3, 2024

@palisadoes a small clarification, the membership request feature is only available for private orgs right ?

@palisadoes
Copy link
Contributor Author

It should be valid for all types of organizations

@Azad99-9
Copy link

Azad99-9 commented Jan 4, 2024

@palisadoes if we remove the support for private orgs then i think the membership request feature is of no use because the public orgs allow the users to directly participate.

Screenshot from 2024-01-04 17-01-58

and in above context the concept of waiting screen also makes no sense.

@Azad99-9
Copy link

Azad99-9 commented Jan 4, 2024

so i am planning to remove both waiting screen and membership request feature from the application.

@palisadoes
Copy link
Contributor Author

  1. When users first create their accounts, they register to an organization and the Admin approves it.
  2. The Admin portal has a request approvals screen for this.
  3. We should consider whether organizations want to have the option of automatic registration or not.

@rishav-jha-mech @aashimawadhwa @beingnoble03 What is the current workflow in the web Admin and User portals?

@rishav-jha-mech
Copy link

Admin Panel

  1. The first registered user becomes Superadmin, others will be just the users
  2. The superadmin creates Organizations, and can manually add any user to it
  3. The superadmin can change the role of any user, from user to admin and vice-versa
  4. An admin cannot change the role of other admin
  5. We have a membership requests page, on Admin Panel, only admins who are not approved by an admin will be listed there, it is redundant now, so that will be removed
  6. We dont have Membership Requests screen at the moment for the organization, we have to create one

@Azad99-9
Copy link

Azad99-9 commented Jan 5, 2024

@rishav-jha-mech please clarify

  1. if an organisation is public, then the users can directly join that org right? No need of sending a membership request and waiting for the approval.

@Azad99-9
Copy link

Azad99-9 commented Jan 6, 2024

so i am planning to remove both waiting screen and membership request feature from the application.

@palisadoes please suggest, what would be the appropriate solution shall I remove the above screens or leave them as it is.

@palisadoes
Copy link
Contributor Author

@rishav-jha-mech please clarify

  1. if an organisation is public, then the users can directly join that org right? No need of sending a membership request and waiting for the approval.

There may be a requirement by the admin to require registration approvals for public orgs.

Please reference the issues mentioned in the other tepos

@palisadoes
Copy link
Contributor Author

Please work with @rishav-jha-mech on this

@palisadoes
Copy link
Contributor Author

Please refer to this discussion before proceeding

@Azad99-9
Copy link

@palisadoes this is for your kind information,
as soon as this PR gets merged i will work on this issue.

@palisadoes
Copy link
Contributor Author

FYI - The issue blocking this has been completed

@Azad99-9
Copy link

Thanks @palisadoes , I will start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants