Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Deprecate Titles for Non-Pinned Posts #2351

Open
palisadoes opened this issue Jan 24, 2024 · 24 comments
Open

Mobile: Deprecate Titles for Non-Pinned Posts #2351

palisadoes opened this issue Jan 24, 2024 · 24 comments
Labels

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2024

Is your feature request related to a problem? Please describe.

Our post feature has never worked as expected. The original idea was for only pinned posts created by Admins requiring titles to attract greater attention, all other posts would not have them.

Social media platforms do not require titles for news feed posts, this is because it adds a step that increases the risk of low interaction rates. We need to implement this as per the original design.

Describe the solution you'd like

API

  1. The API must only require titles for pinned posts. All other post types must generate an appropriate error if a title is provided.
  2. Pinned posts can only be created by Super Admins or Admins for the organization where the post was created

Admin

  1. Only pinned posts must require titles.
  2. Non Pinned Posts
    1. Post screens not related to pinned posts must not display titles (As they won’t exist)
  3. There must be no CRUD activity related the titles of regular post
  4. Pinned posts can only be created by Super Admins or Admins for the organization where the post was created

Mobile

  1. The mobile app must not allow the creation of pinned posts as this is an Admin function
  2. There must be no CRUD activity related the titles of regular post
  3. Pinned posts can only be created by Super Admins or Admins for the organization where the post was created

Other

  1. All tests for this functionality update must be valid
  2. No other functionality must be altered

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • N/A

Additional context

Related issues:

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@abhinavs1920
Copy link

I want to work on this issue, my skills align with this issue.

@Azad99-9
Copy link

@abhinavs1920 make sure you tag queue reviewers when requesting for issue assignment. so that they get to see your comment.
for now i am tagging them on your behalf @noman2002 @Cioppolo14 @nishnatadebnath

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Jan 27, 2024
@palisadoes
Copy link
Contributor Author

The API work is complete. You can start on your work

Copy link

github-actions bot commented Feb 8, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 8, 2024
@abhinavs1920
Copy link

I am working on it give me some more time

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 9, 2024
@Dante291
Copy link

Dante291 commented Feb 13, 2024

@abhinavs1920 still working on this? This need to be fixed as it is fixed from backend side so now making new post will throw an error so this need to be fixed asap, If you're not working on this let me handle this issue.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 24, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Feb 24, 2024
@Cioppolo14
Copy link

Unassigning due to no open PR or activity. @Dante291 if you have less than 2 issues assigned right now and are still interested in this issue, let me know.

@imshivam-gupta
Copy link

HI can u assign this to me

@imshivam-gupta
Copy link

I have started working on this

@imshivam-gupta
Copy link

@palisadoes Can you please elaborate 2nd point

There must be no CRUD activity related the titles of regular post

@palisadoes
Copy link
Contributor Author

  1. Titles must not be visible or editable for regular posts.
  2. Pinned posts cannot be converted to regular posts and vice versa

In the near future we'll need to create a separate post type to more easily separate the functionality

@imshivam-gupta
Copy link

The API functionality for preventing posts with titles hasn't been implemented properly, as evidenced by the ability to create such posts. There seems to be a flaw in the implementation on the API side.

@imshivam-gupta
Copy link

The API functionality for preventing posts with titles hasn't been implemented properly, as evidenced by the ability to create such posts. There seems to be a flaw in the implementation on the API side.

@palisadoes should I open an issue for the same

@palisadoes
Copy link
Contributor Author

Yes, you don't have to ask to create issues

@imshivam-gupta imshivam-gupta removed their assignment Mar 9, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 20, 2024
@chiragtyagi2003
Copy link

If for mobile app this hasn't been solved yet, please assign this to me.

@chiragtyagi2003
Copy link

Hi @Cioppolo14 cloud you provide clarity about whether I should consider the code of the develop branch or the main branch? Also I have found some bugs and points for major improvements and would like to discuss it further.

@Cioppolo14
Copy link

@chiragtyagi2003 Please use the develop branch. The main branch is not the most recent code.

@chiragtyagi2003
Copy link

chiragtyagi2003 commented Mar 21, 2024

@Cioppolo14 Considering the develop branch, there are many UI, which I think should be improved, Also there is no guidance or search about the community URLs creating confusion for new users.

@Cioppolo14
Copy link

@chiragtyagi2003 Please search through the issues we have right now, I know we have a lot of changes happening. If you find a new issue, feel free to propose it and our team will review the exact issue and proposed solution. We are focused on major bugs and fixes right now. Thank you for exploring the Talawa repos and looking for ways to improve them!

Copy link

github-actions bot commented Apr 2, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 2, 2024
@Cioppolo14
Copy link

Unassigning due to no activity or PR

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 3, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants