-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Optimizing dialog box for iOS #270
Comments
@Sagar2366 Should I reopen this issue and the PR made for this? |
May I correct you with the title currently flutter doesn't support the metal for iOS there is no way to possible to optimize the dialog. I feel what you current might be addressing is change the current material design alert dialog to cupertino style. Correct me if I am not wrong. |
If the Platform is iOS then we will be showing showCupertinoDialog instead of showDialog thats why I name the title as optimising dialog box for iOS as PR will deal with showCupertinoDialog code. In the PR #271, I used the showCupertinoDialog (under the condition if Platform is iOS) and didn't face any issue. |
I guess this would just change the design from material to cupertino which is preferred design style for iOS. |
BTW there are already dedicated files added by me for alert dialogs. |
That is what the Issue and PR is all about |
I checked the current file and it is still using showDialog. So thought about using platform specific if else statement and show dialoge accordingly. But now will surely look into alert_dialogue first and decide accordingly. |
* Bump y18n from 4.0.0 to 4.0.1 Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * fix: Create INSTALLATION.md File (PalisadoesFoundation#220) * Updated INSTALLATION.md Node js is not needed for Docker installation * Deleted docs folder * Fixes PalisadoesFoundation#222 * Add files via upload * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update PR-guidelines.md * Update CONTRIBUTING.md * Update issue.yml * Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> * Create linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Create test.js * Update test.js * Update test.js * Update test.js * Update test.js * Update test.js * Update linter.yml * Update linter.yml * Delete test.js * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Create lint.yml * Update linter.yml * Delete lint.yml * Update linter.yml * bug issue#223 resolved * bug fix issue PalisadoesFoundation#223 * Delete chats.spec.js * Delete chats.spec.dev.js * Create chats.spec.js * Updated branching strategy in CONTRIBUTING.md * bug: PalisadoesFoundation#253 netmask bump * bug: PalisadoesFoundation#253 netmask bump * Pagination for members of organization * feat: PalisadoesFoundation#263 Added i18n, error interface library * bugFix: PalisadoesFoundation#254 Bumped up node-notifier * feat: PalisadoesFoundation#263 fixed error objects * feat: PalisadoesFoundation#263 fixed naming conventions * feat: PalisadoesFoundation#263 fixed linting * feat: PalisadoesFoundation#263 fixed errors * feat: PalisadoesFoundation#263 format graphql error object * feat: PalisadoesFoundation#263 Fixed plural validation error handling * feat: PalisadoesFoundation#263 Added util function * feat: PalisadoesFoundation#263 Added hindi translations * feat: PalisadoesFoundation#263 Added hindi translations * feat: PalisadoesFoundation#263 Added comments for error classes * feat: PalisadoesFoundation#263 Added ['hi', 'en', 'zh', 'fr', 'sp'] supported languages * feat: PalisadoesFoundation#263 Packaged errors and talawa-request-context as library * feat: PalisadoesFoundation#263 Packaged errors and talawa-request-context as library * feat: PalisadoesFoundation#263 Fixed eslint errors * Update pull_request_template.md * Feature/logging (PalisadoesFoundation#267) * feat: PalisadoesFoundation#264 logger * feat: PalisadoesFoundation#264 removed nanoid * feat: PalisadoesFoundation#264 added custom libs * feat: PalisadoesFoundation#264 added custom libs * feat: PalisadoesFoundation#264 removed request tracing * feat: PalisadoesFoundation#264 Used custom lib logger * feat: PalisadoesFoundation#264 Compatible request tracing via logger * feat: PalisadoesFoundation#264 Logging error message * Update Installation.md (PalisadoesFoundation#270) Clarify more with the required steps for installation. * Pagination added for posts by organisation (PalisadoesFoundation#273) * pagination added for posts by org * es lint fix * Model and Schema update for appLanguage (PalisadoesFoundation#281) * model and schema update * language update mutation added * language code added * lng * bugFix: PalisadoesFoundation#288 ws package upgrade (PalisadoesFoundation#293) * bug fix : events can be removed by event admins or org admins only (PalisadoesFoundation#271) * bug fix : events can be removed by event admins or org admins only * replaced .filter method with .includes * replaced errors with error objects for translation * Schema Update to avoid master failure (PalisadoesFoundation#299) * changes for workflow update Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <blackriver@simiya.com> Co-authored-by: Saumya Pandey <sp160899@gmail.com> Co-authored-by: Hrishikesh-Bhagwat <79875904+Hrishikesh-Bhagwat@users.noreply.github.com> Co-authored-by: ShubhamBhardwaj <shubham.11901502@lpu.in> Co-authored-by: mihdas <46824909+mihdas@users.noreply.github.com> Co-authored-by: ssaumyaa7 <saumya4799@gmail.com> Co-authored-by: DangaRanga <jasonblue1626@gmail.com> Co-authored-by: Jason Gayle <55003601+DangaRanga@users.noreply.github.com> Co-authored-by: impiyush83 <nalawadepiyush@gmail.com> Co-authored-by: Uttam kumar <72701081+helper-uttam@users.noreply.github.com> Co-authored-by: Akshat Garg <60404253+akshatgarg12@users.noreply.github.com>
…n#282) * Bump y18n from 4.0.0 to 4.0.1 Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * fix: Create INSTALLATION.md File (PalisadoesFoundation#220) * Updated INSTALLATION.md Node js is not needed for Docker installation * Deleted docs folder * Fixes PalisadoesFoundation#222 * Add files via upload * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update PR-guidelines.md * Update CONTRIBUTING.md * Update issue.yml * Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> * Create linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Create test.js * Update test.js * Update test.js * Update test.js * Update test.js * Update test.js * Update linter.yml * Update linter.yml * Delete test.js * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Update linter.yml * Create lint.yml * Update linter.yml * Delete lint.yml * Update linter.yml * bug issue#223 resolved * bug fix issue PalisadoesFoundation#223 * Delete chats.spec.js * Delete chats.spec.dev.js * Create chats.spec.js * Updated branching strategy in CONTRIBUTING.md * bug: PalisadoesFoundation#253 netmask bump * bug: PalisadoesFoundation#253 netmask bump * Pagination for members of organization * feat: PalisadoesFoundation#263 Added i18n, error interface library * bugFix: PalisadoesFoundation#254 Bumped up node-notifier * feat: PalisadoesFoundation#263 fixed error objects * feat: PalisadoesFoundation#263 fixed naming conventions * feat: PalisadoesFoundation#263 fixed linting * feat: PalisadoesFoundation#263 fixed errors * converted promise/callback syntax to async-await * feat: PalisadoesFoundation#263 format graphql error object * feat: PalisadoesFoundation#263 Fixed plural validation error handling * feat: PalisadoesFoundation#263 Added util function * feat: PalisadoesFoundation#263 Added hindi translations * feat: PalisadoesFoundation#263 Added hindi translations * feat: PalisadoesFoundation#263 Added comments for error classes * feat: PalisadoesFoundation#263 Added ['hi', 'en', 'zh', 'fr', 'sp'] supported languages * feat: PalisadoesFoundation#263 Packaged errors and talawa-request-context as library * feat: PalisadoesFoundation#263 Packaged errors and talawa-request-context as library * feat: PalisadoesFoundation#263 Fixed eslint errors * Update pull_request_template.md * Feature/logging (PalisadoesFoundation#267) * feat: PalisadoesFoundation#264 logger * feat: PalisadoesFoundation#264 removed nanoid * feat: PalisadoesFoundation#264 added custom libs * feat: PalisadoesFoundation#264 added custom libs * feat: PalisadoesFoundation#264 removed request tracing * feat: PalisadoesFoundation#264 Used custom lib logger * feat: PalisadoesFoundation#264 Compatible request tracing via logger * feat: PalisadoesFoundation#264 Logging error message * Update Installation.md (PalisadoesFoundation#270) Clarify more with the required steps for installation. * Pagination added for posts by organisation (PalisadoesFoundation#273) * pagination added for posts by org * es lint fix * Model and Schema update for appLanguage (PalisadoesFoundation#281) * model and schema update * language update mutation added * language code added * lng * bugFix: PalisadoesFoundation#288 ws package upgrade (PalisadoesFoundation#293) * lint issues fixed * updated package-lock to fix lint err Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <blackriver@simiya.com> Co-authored-by: Saumya Pandey <sp160899@gmail.com> Co-authored-by: Hrishikesh-Bhagwat <79875904+Hrishikesh-Bhagwat@users.noreply.github.com> Co-authored-by: ShubhamBhardwaj <shubham.11901502@lpu.in> Co-authored-by: mihdas <46824909+mihdas@users.noreply.github.com> Co-authored-by: ssaumyaa7 <saumya4799@gmail.com> Co-authored-by: DangaRanga <jasonblue1626@gmail.com> Co-authored-by: Jason Gayle <55003601+DangaRanga@users.noreply.github.com> Co-authored-by: impiyush83 <nalawadepiyush@gmail.com> Co-authored-by: Sumitra Saksham <35868598+sumitra19jha@users.noreply.github.com> Co-authored-by: Uttam kumar <72701081+helper-uttam@users.noreply.github.com>
Every Dialog Box until now is created with a Ui interface displayed on android. This issue deals with the fact that dialog box can be optimised for making sure of the iOS experience on iOS Devices.
Following dialogue box can be optimized:
The enhancement will be great thinking from iOS perspective.
The text was updated successfully, but these errors were encountered: