Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password show/hide button removed from Registration form #291

Closed
CoderMayhem opened this issue Mar 14, 2021 · 2 comments
Closed

Password show/hide button removed from Registration form #291

CoderMayhem opened this issue Mar 14, 2021 · 2 comments
Labels
unapproved Unapproved, needs to be triaged

Comments

@CoderMayhem
Copy link
Contributor

Issue Description
In recently made changes to the registration form someone removed the password show/hide feature from the password field. It needs to be added again and the UI of Login form needs to be updated as per the UI of the Registration form.

Working on this?
Fixed. Linking PR below.
@CoderMayhem CoderMayhem mentioned this issue Mar 14, 2021
Merged
@Sagar2366
Copy link
Contributor

This is not good. Can you please check which PR reverted this ?

@CoderMayhem
Copy link
Contributor Author

It was done in PR #238 in this commit . @Sagar2366

@jordanliu jordanliu added the unapproved Unapproved, needs to be triaged label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unapproved Unapproved, needs to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jordanliu @Sagar2366 @CoderMayhem