Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discussion] [Enhancement] Most of the pages keep loading when data is empty. #298

Closed
AniketSindhu opened this issue Mar 14, 2021 · 5 comments
Closed

[Discussion] [Enhancement] Most of the pages keep loading when data is empty. #298

AniketSindhu opened this issue Mar 14, 2021 · 5 comments
Assignees
@AniketSindhu
Labels
bug Something isn't working

Comments

@AniketSindhu
Copy link
Contributor

AniketSindhu commented Mar 14, 2021 •
edited

I am thinking of showing some error screen after some fixed time like 10 seconds. Because infinite loading is not good for user experience.

I am willing to work on this if maintainers are ok with this approach
@CyberWake CyberWake mentioned this issue Mar 16, 2021
Closed
@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Mar 16, 2021
@AniketSindhu
Copy link
Contributor Author

AniketSindhu commented Mar 18, 2021 •
edited

@CyberWake @jordanliu @palisadoes Should I create PR for this?

@CoderMayhem CoderMayhem mentioned this issue Mar 20, 2021
Closed
@CoderMayhem
Copy link
Contributor

Any updates on this @AniketSindhu ?

@AniketSindhu
Copy link
Contributor Author

@CoderMayhem code is on freeze. So if I make PR on this now it will not be merged so I am justing waiting for it to unfreeze.

@Sagar2366 Sagar2366 added bug Something isn't working and removed enhancement unapproved Unapproved, needs to be triaged labels Mar 21, 2021
@Sagar2366
Copy link
Contributor

@AniketSindhu you can start working on this issue.

@CoderMayhem CoderMayhem mentioned this issue Mar 21, 2021
Closed
@AniketSindhu AniketSindhu mentioned this issue Mar 22, 2021
Merged
@AniketSindhu
Copy link
Contributor Author

@Sagar2366 PR #456 submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AniketSindhu AniketSindhu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jordanliu @palisadoes @Sagar2366 @CoderMayhem @AniketSindhu