Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Enhancement] Remove Pageview for login screens. #322

Closed
Swayam221 opened this issue Mar 15, 2021 · 6 comments · Fixed by #412
Closed

[Bug/Enhancement] Remove Pageview for login screens. #322

Swayam221 opened this issue Mar 15, 2021 · 6 comments · Fixed by #412
Assignees

Comments

@Swayam221
Copy link
Contributor

Swayam221 commented Mar 15, 2021

Issue description:
As of now on the logic screen, user can swipe between the url screen and login, register pages. This has been implemented with PageView. With the login and create an account buttons on there being on the url screen, it makes more sense to let only those buttons navigate to those screens rather than the swipe. This will also include fixing the bug that there is no back button on login and signup pages to get back to the url screens.
Issue severity:
medium
Environment details:
would require major changes in the file https://github.com/PalisadoesFoundation/talawa/blob/master/lib/views/pages/login_signup/login_page.dart and also other changes in the login_signup folder.
Observed behaviour: User can wipe on the login url setting screen to login and signup pages though there are buttons present to navigate to them; there are no back buttons on the login/singup screens to reach back to the url setting screen.
Expected behaviour:
after the change, the user will no longer be able to swipe, and would be able to reach back to the Url screen with back buttons only.
I am willing to work on this issue.

@adithyaakrishna
Copy link
Contributor

This is a great one @Swayam221 🎉

@jordanliu
Copy link
Contributor

Assigned

@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Mar 16, 2021
@jordanliu jordanliu removed the unapproved Unapproved, needs to be triaged label Mar 17, 2021
@Sagar2366 Sagar2366 added the hold label Mar 17, 2021
@Sagar2366
Copy link
Contributor

Sagar2366 commented Mar 19, 2021

@Swayam221 instead of saving form details.
Can you disable swipe for signup/login ?
Flow should be : Provide valid organization URL -> Click on Set URL -> Click on signup/login button to proceed.
Also update issue description for the same - issue template (https://github.com/PalisadoesFoundation/talawa/tree/master/templates)

@Swayam221
Copy link
Contributor Author

Swayam221 commented Mar 19, 2021

@Swayam221 instead of saving form details.
Can you disable swipe for signup/login ?
Flow should be : Provide valid organization URL -> Click on Set URL -> Click on signup/login button to proceed.
Also update issue description for the same - issue template (https://github.com/PalisadoesFoundation/talawa/tree/master/templates)

@Sagar2366 are we sure we want the wipe disable? because if we do that, once the URL is set and we press, lets suppose, the signup button, we wont be able to navigate back to the setURL page at all, which means it will be impossible to change the URL once set and navigated to another page

@Sagar2366
Copy link
Contributor

@Swayam221 instead of saving form details.
Can you disable swipe for signup/login ?
Flow should be : Provide valid organization URL -> Click on Set URL -> Click on signup/login button to proceed.
Also update issue description for the same - issue template (https://github.com/PalisadoesFoundation/talawa/tree/master/templates)

@Sagar2366 are we sure we want the wipe disable? because if we do that, once the URL is set and we press, lets suppose, the signup button, we wont be able to navigate back to the setURL page at all, which means it will be impossible to change the URL once set and navigated to another page

Based on current flow, yes it is difficult. We should add back functionality in signup page and login page to go back to the URL setting page and try signing up or login again. I will create new issue for that.
For now please proceed with this issue.

@Swayam221
Copy link
Contributor Author

@Swayam221 instead of saving form details.
Can you disable swipe for signup/login ?
Flow should be : Provide valid organization URL -> Click on Set URL -> Click on signup/login button to proceed.
Also update issue description for the same - issue template (https://github.com/PalisadoesFoundation/talawa/tree/master/templates)

@Sagar2366 are we sure we want the wipe disable? because if we do that, once the URL is set and we press, lets suppose, the signup button, we wont be able to navigate back to the setURL page at all, which means it will be impossible to change the URL once set and navigated to another page

Based on current flow, yes it is difficult. We should add back functionality in signup page and login page to go back to the URL setting page and try signing up or login again. I will create new issue for that.
For now please proceed with this issue.

@Sagar2366 okay sure! I could take up that new issue too.

@Swayam221 Swayam221 changed the title [Enhancement] Save form details on signup page [Enhancement] Remove Pageview for login screens. Mar 19, 2021
@Swayam221 Swayam221 changed the title [Enhancement] Remove Pageview for login screens. [Bug/Enhancement] Remove Pageview for login screens. Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants