-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug/Enhancement] Remove Pageview for login screens. #322
Comments
This is a great one @Swayam221 🎉 |
Assigned |
@Swayam221 instead of saving form details. |
@Sagar2366 are we sure we want the wipe disable? because if we do that, once the URL is set and we press, lets suppose, the signup button, we wont be able to navigate back to the setURL page at all, which means it will be impossible to change the URL once set and navigated to another page |
Based on current flow, yes it is difficult. We should add back functionality in signup page and login page to go back to the URL setting page and try signing up or login again. I will create new issue for that. |
@Sagar2366 okay sure! I could take up that new issue too. |
Issue description:
As of now on the logic screen, user can swipe between the url screen and login, register pages. This has been implemented with PageView. With the login and create an account buttons on there being on the url screen, it makes more sense to let only those buttons navigate to those screens rather than the swipe. This will also include fixing the bug that there is no back button on login and signup pages to get back to the url screens.
Issue severity:
medium
Environment details:
would require major changes in the file https://github.com/PalisadoesFoundation/talawa/blob/master/lib/views/pages/login_signup/login_page.dart and also other changes in the login_signup folder.
Observed behaviour: User can wipe on the login url setting screen to login and signup pages though there are buttons present to navigate to them; there are no back buttons on the login/singup screens to reach back to the url setting screen.
Expected behaviour:
after the change, the user will no longer be able to swipe, and would be able to reach back to the Url screen with back buttons only.
I am willing to work on this issue.
The text was updated successfully, but these errors were encountered: