Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Home Screen hero animation error #634

Closed
sumitra19jha opened this issue Apr 9, 2021 · 7 comments · Fixed by #694
Closed

[BUG] Home Screen hero animation error #634

sumitra19jha opened this issue Apr 9, 2021 · 7 comments · Fixed by #694
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sumitra19jha
Copy link
Contributor

sumitra19jha commented Apr 9, 2021

Issue Description

Error occur in comment screen due to the user of hero animation

Issue Severity

Low

Observed Behaviour:

Error displayed in the console

Expected Behaviour:

Either Hero animation should not be used or its implemented should be corrected

Steps to reproduce issue:

  1. Press on event page
  2. Press on Home Page
  3. Press comment
  4. Navigate Back

Snapshots/Videos:

Within each subtree for which heroes are to be animated (i.e. a PageRoute subtree), each Hero must have a unique non-null tag.
In this case, multiple heroes had the following tag: <default FloatingActionButton tag>
Here is the subtree for one of the offending heroes: Hero
    tag: <default FloatingActionButton tag>
    dependencies: [_ModalScopeStatus]
    state: _HeroState#18757
When the exception was thrown, this was the stack
#0      Hero._allHeroesFor.inviteHero.<anonymous closure>
package:flutter/…/widgets/heroes.dart:256
#1      Hero._allHeroesFor.inviteHero
package:flutter/…/widgets/heroes.dart:267
#2      Hero._allHeroesFor.visitor
package:flutter/…/widgets/heroes.dart:295
#3      SingleChildRenderObjectElement.visitChildren
package:flutter/…/widgets/framework.dart:5961
#4      Hero._allHeroesFor.visitor
package:flutter/…/widgets/heroes.dart:301

Does this issue need immediate attention?

No

Are you willing to work on this issue

Yes.

Other information:

It is a very minor issue and hero animation in the home screen is needed to be replaced

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 9, 2021
@Sagar2366 Sagar2366 added bug Something isn't working good first issue Good for newcomers and removed unapproved Unapproved, needs to be triaged labels Apr 9, 2021
@Sagar2366
Copy link
Contributor

@sumitra19jha assigned another issue to you.
Let someone else work on this issue, preferably newly joined students for GSoC.

@sumitra19jha
Copy link
Contributor Author

Sure

@sandeep-v1404
Copy link

@Sagar2366 Can I work on this issue ?

@yasharth291
Copy link
Contributor

is this issue still open if yes I want to work on it @Sagar2366 sir

@sandeep-v1404
Copy link

sandeep-v1404 commented Apr 19, 2021

@yasharth291 I am currently learning Flutter. You can take up this task .

@sandeep-v1404 sandeep-v1404 removed their assignment Apr 19, 2021
@yasharth291
Copy link
Contributor

thanks sandeep @Sagar2366 sir could you assign me this

@yasharth291
Copy link
Contributor

thank u so much sir working on it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants