Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No validation of input URL whether it an endpoint to Talawa server or not #649

Closed
Hrishikesh-Bhagwat opened this issue Apr 13, 2021 · 1 comment
Closed

No validation of input URL whether it an endpoint to Talawa server or not #649

Hrishikesh-Bhagwat opened this issue Apr 13, 2021 · 1 comment
Labels
unapproved Unapproved, needs to be triaged

Comments

@Hrishikesh-Bhagwat
Copy link
Contributor

Issue Description:
When a user enters a URL to a Talawa server, there is no verification to check if this is a valid URL. For example, even google's URL may be considered valid when it is not a Talawa endpoint

Issue Severity:
Slight- as users who do not know about the app might not know what is happening

Observed Behaviour:
Any link is accepted as a URL whether it is associated with Talawa or not

Expected Behaviour:
Only a Talawa URL must be accepted as a valid URL.

Steps to reproduce issue:
Enter any URL and it will be accepted as a valid URL.

Are you willing to work on this issue?
Yep :)
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 13, 2021
@Sagar2366
Copy link
Contributor

As discussed in slack channel, we do not need this feature.
Please follow community guidelines and discuss in slack channel before creating any new issue.

Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
@saga0p
Test for directchats (PalisadoesFoundation#649)
43130e5 
* test for directChatsMessagesByChatId

* conflict fixed for chatsbychatId

* test for directChatMessages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unapproved Unapproved, needs to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sagar2366 @Hrishikesh-Bhagwat