Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint the Code Base - Top Priority #691

Closed
palisadoes opened this issue Apr 22, 2021 · 4 comments
Closed

Lint the Code Base - Top Priority #691

palisadoes opened this issue Apr 22, 2021 · 4 comments
Assignees

Comments

@palisadoes
Copy link
Contributor

We were having a large number of issues with code conflicts due to unlinted code. We have now added automated linting to the PR process, but will need to lint the entire codebase to this new standard.

Linting will include following the steps in the automation script shown here. Specifically:

  1. Run Dart Analyzer on the codebase
  2. Fix all Dart Analyzer issues. This must be completed before proceeding to the next step.
  3. Run the flutter format command on the code base
    1. flutter format --set-exit-if-changed .

Coordinate with @DeltaHarbinger and @Sagar2366 on this issue.

We will reopen PRs when this issue is resolved. We are looking for someone to work on this quickly.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 22, 2021
@sumitra19jha
Copy link
Contributor

sumitra19jha commented Apr 22, 2021

If possible, can I work on this issue?

@Neha62-lit
Copy link

Neha62-lit commented Apr 22, 2021

I already opened this issue, but still my PR is on hold.
Issue no #400

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Apr 22, 2021
@palisadoes
Copy link
Contributor Author

@Neha62-lit Would Pedantic create a differences in the output when compared to the approach we are using?

@palisadoes
Copy link
Contributor Author

@sumitra19jha Use this issue to lint the develop branch. Use this method to automatically close the issue when the PR is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants