Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build by adding glide spec, add AWS CloudBuild support #36

Merged
merged 9 commits into from
Jan 25, 2017
Merged

Fixed build by adding glide spec, add AWS CloudBuild support #36

merged 9 commits into from
Jan 25, 2017

Conversation

whereisaaron
Copy link
Contributor

In order to make changes I needed to get the project building. There were two problems:

  1. The current go-client alpha is in the middle of breaking changes, I needed to peg the previous version, so I added a glide.yaml/glide.lock to enable that.
  2. I added automated build, container build, and push to Docker Hub support using AWS CloudBuild.
    I haven't changed the functionality at all in the PR. I'll do seperate PR's for that. This is just for clean, automated builds.

@luna-duclos
Copy link

+1 on the vendor changes
not sure how I feel on the AWS stuff yet, need to give it a good read. Wondering if we also want to support the google equivalent of this.

@luna-duclos
Copy link

Been pondering about this, would you find it reasonable to move all the AWS specific stuff to a subfolder called aws/ ? Mainly so that things don't get confusing if we add support for other cloud builders later on

@whereisaaron
Copy link
Contributor Author

I wondered about including it at all. But then the barrier to contributing is mostly having an easy way to build and test changes. So I thought better to share. I'd like to see some build instructions added to the README.

I can move it where you like, except that buildspec.yml does need to be in the root of the repo to work with CodeBuild. I'd suggest a /codebuild so e.g. you can have a /travisci, /codeship, /teamcity folder if people have build specs for those.

I'll reorganize it.

@whereisaaron
Copy link
Contributor Author

I have shifted everything except buildspec.yml into a codebuild folder with its own README.md. Added a link to README.md in the root README.md. I marked the existing, local build build.sh and build-container.sh scripts as executable.

@whereisaaron
Copy link
Contributor Author

@luna-duclos my -class branch in on top of this codebuild branch, so I'll wait until you decide on this PR before doing the next PR

@luna-duclos
Copy link

I'll try and look at this in the morning, been busy over the weekend

@luna-duclos luna-duclos merged commit 84bb913 into PalmStoneGames:master Jan 25, 2017
whereisaaron added a commit to whereisaaron/kube-cert-manager that referenced this pull request Jan 25, 2017
@whereisaaron
Fixed build by adding glide spec, add AWS CloudBuild support (PalmSto…
fdcb544 
…neGames#36)

* Create glide.yaml to enable the project to build (breaking changes in go-client v2.0.0-alpha.1)
Fix Wrap to Wrapf is message call

* Add a buildspec.yml for AWS CodeBuild

* Add scripts to start CodeBuild build from the command line and to display the build log

* Move AWS CodeBuild info and scripts into a 'codebuild' folder, 'buildspec.yml' is required to stat in the repo root folder

* Mark the existing build.sh and build-container.sh files as executable

* Improve sample codebuild build.dev example
@whereisaaron whereisaaron deleted the cloudbuild branch January 25, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whereisaaron @luna-duclos