-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix createPostmanCollection method where a copy of openapiData is generated #183
Conversation
…avoid deleting server object in pathItems
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
Visit the preview URL for this PR (updated for commit 57b57b5): https://docusaurus-openapi-36b86--pr183-tz6wbim6.web.app (expires Wed, 31 Aug 2022 19:44:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Hi @johnnyswan, thanks for your contribution! The Change this:
To this:
As for the |
I plan to use |
Gotcha - definitely excited to see what you have in mind! In that case, I think it's best to leave the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove groupId
from createAuthentication
until new SecurityScheme component is introduced. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
Can you please say when will be the release of this fix? I have the same issue. |
Hi @TarasMelnyk, we should have a new production release out later this week. If you need it sooner, you can always upgrade to a canary release, which auto publishes whenever we merge to main. |
Description
This PR introduces the following changes:
createPostmanCollection
method where a copy ofopenapiData
is generatedgroupId
toTabs
component for Authentication section in generated*.info.mdx
fileMotivation and Context
The previous realization with
Object.assign
does not copy nested objects, and the next operation with deleting 'servers' attributes removes them into the parent object too.*.info.mdx
file does not save user choice to storage and does not change security scheme all over the documentationHow Has This Been Tested?
Environment: Local
Changes were tested by viewing specific API docs to ensure functionality for API docs were intact and ensuring that the app builds successfully upon each change.
Types of changes
Checklist