-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Ensure operation tags match global tags before building sidebar #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 3.6 MB ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 168033d): https://docusaurus-openapi-36b86--pr202-hqhkwqzl.web.app (expires Sat, 10 Sep 2022 12:18:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is a regression bug introduced while addressing #199. Essentially, matching operation tag to global tag was failing when
x-displayName
was present. This change eliminates that possibility by avoiding resolvingx-displayName
until immediately before the category label is assigned.Motivation and Context
Regression bug fix.
How Has This Been Tested?
Tested with both Petstore and the sample Unleash API spec.
Screenshots (if appropriate)
n/a
Types of changes