Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo TabTtem -> TabItem #212

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

jeffora
Copy link
Contributor

@jeffora jeffora commented Aug 16, 2022

There is a typo in the markdown generator code that is pulling in a TabTtem rather than a TabItem as expected.

@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit b556957):

https://docusaurus-openapi-36b86--pr212-bzj2l71k.web.app

(expires Thu, 15 Sep 2022 11:27:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@sserrata
Copy link
Member

Thanks for the PR @jeffora! I actually just noticed it after submitting a similar fix. I will close mine so we can merge yours instead.

It looks good but can you also please re-generate the API docs by running the following under the ./demo directory?

yarn docusaurus clean-api-docs all
yarn docusaurus clean-api-docs:version petstore_versioned:all
yarn docusaurus gen-api-docs all
yarn docusaurus gen-api-docs:version petstore_versioned:all

@sserrata
Copy link
Member

On second thought, since I'm planning to work on updating docs, I'll merge as-is and follow up with another PR. Thanks!

@sserrata sserrata merged commit 2bdf6a8 into PaloAltoNetworks:main Aug 16, 2022
@welcome-to-palo-alto-networks

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

@jeffora jeffora deleted the fix/tab-item-typo branch August 17, 2022 00:44
@jeffora
Copy link
Contributor Author

jeffora commented Aug 17, 2022

Thanks for the fast turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants