Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for languageTabs and request method labels. #256

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Add documentation for languageTabs and request method labels. #256

merged 3 commits into from
Sep 12, 2022

Conversation

homotechsual
Copy link
Contributor

Description

This documents setting the languageTabs and customising the request method labels.

Motivation and Context

Documentation only change to document language tabs and request method label css.

How Has This Been Tested?

N/A

Types of changes

  • Documentation: Changes to documentation content only.

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@github-actions
Copy link

github-actions bot commented Sep 11, 2022

Visit the preview URL for this PR (updated for commit b96e7fd):

https://docusaurus-openapi-36b86--pr256-7ubaema2.web.app

(expires Wed, 12 Oct 2022 13:51:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only a couple of minor changes requested:

  • Can we revert docusaurus.config.js changes? It appears powershell was added although not yet supported.
  • Could we rename "customisation" to "customization" for consistency?

@homotechsual
Copy link
Contributor Author

Should have just those requested changes now @sserrata :-)

Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that languagetabs.md is still referencing "powershell" in the example. Probably best to clean that up as well. Thanks!

@sserrata
Copy link
Member

By the way, we can definitely add support for "powershell". I would have already included it but I couldn't find a suitable SVG icon on DEVICON.

@sserrata sserrata self-requested a review September 12, 2022 13:55
Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sserrata sserrata merged commit fe0c219 into PaloAltoNetworks:main Sep 12, 2022
@homotechsual
Copy link
Contributor Author

There is a PowerShell icon accepted into DEVICON's develop branch!

@homotechsual homotechsual deleted the docs-updates branch September 12, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants