-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for languageTabs and request method labels. #256
Conversation
Visit the preview URL for this PR (updated for commit b96e7fd): https://docusaurus-openapi-36b86--pr256-7ubaema2.web.app (expires Wed, 12 Oct 2022 13:51:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only a couple of minor changes requested:
- Can we revert
docusaurus.config.js
changes? It appearspowershell
was added although not yet supported. - Could we rename "customisation" to "customization" for consistency?
Should have just those requested changes now @sserrata :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that languagetabs.md
is still referencing "powershell" in the example. Probably best to clean that up as well. Thanks!
By the way, we can definitely add support for "powershell". I would have already included it but I couldn't find a suitable SVG icon on DEVICON. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There is a PowerShell icon accepted into |
Description
This documents setting the languageTabs and customising the request method labels.
Motivation and Context
Documentation only change to document language tabs and request method label css.
How Has This Been Tested?
N/A
Types of changes
Checklist