[Bug] Implement selective escape for sanitizing titles and descriptions #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +201 kB (+5%) 🔍 Total Size: 3.96 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 0d822b5): https://docusaurus-openapi-36b86--pr301-5616eb4s.web.app (expires Thu, 17 Nov 2022 13:38:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
@sserrata Tested with IOT and the expected behavior looks great. Although, I did notice a similar issue for our Before: After: I can push up these changes if they check out 👍 |
|
Nice! Feel free to push the changes. |
|
Just need to make sure we have enough coverage of HTML and any potential Docusaurus-specific tags. |
I believe the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #299 for background.
This PR implements selective replace for
<and>characters in order to preserve support for inline HTML. Previously,lodashescape()was being used to HTML-encode all special characters, which broke inline-HTML.Motivation and Context
Renders titles and descriptions as intended, including HTML.
How Has This Been Tested?
Tested with Petstore and IOT APIs but more testing will be welcomed to ensure no regression bugs are introduced.
Additional testing with Threat Prevention API.