-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when allOf two refs #335
Conversation
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
Visit the preview URL for this PR (updated for commit 43bac65): https://docusaurus-openapi-36b86--pr335-7ro33da0.web.app (expires Fri, 09 Dec 2022 20:46:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @xvladqt. Does it make sense to also add support for x-example
(singular)? Perhaps not single x-example
could only be a single example?
@sserrata if x-example without allOf all good, this problem exists only if allOf with 2+ refs and x-example. If I understand the question correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix linter errors. You may try running yarn run format
. If that doesn't work, try running the format
script manually, i.e. prettier . --check --ignore-unknown --ignore-path .prettierignore
.
I know that sometimes the globally installed prettier
can interfere so you might need to specify you want to run the prettier
installed locally, e.g. ./node_modules/.bin/prettier
.
@sserrata I forget about prettier, fixed it now |
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
Description
Add
x-examples
resolver for json-schema-merge-allofMotivation and Context
Generate throw error:
in this case
How Has This Been Tested?
yarn test
- successTypes of changes
Checklist