Improve handling of non-string default values #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +123 B (0%) Total Size: 6.2 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 4cec991): https://docusaurus-openapi-36b86--pr436-9hdyr5l6.web.app (expires Sat, 18 Mar 2023 14:06:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
It looks like an alternative solution would be to improve the value != undefined (which also includes null if you use ==) or something like that?
|
Yes, I think that can also be improved - at least, it handles the |
sserrata
force-pushed
the
default-values
branch
from
ac92829
to
04c6cc0
Compare
sserrata
changed the title
sserrata
added a commit
that referenced
this pull request
Feb 16, 2023
sserrata
added a commit
that referenced
this pull request
Feb 16, 2023
* Improve handling of non-string default values (#436) * Point to test spec * Add utility for casting to string * More explicitly check for undefined and add code comments to toString() * Revert back to demo petstore spec * Update deploy-preview.yml * Update validate.yaml * Update codeql-analysis.yml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #432
Adds utility for converting/casting various data types to
String:undefinedornullwill returnundefinedArraywill be joined to a formatted stringString