[UI Enhancement] CSS Cleanup/Refactor - Migration to SCSS and BEM-style convention #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9e71c99): https://docusaurus-openapi-36b86--pr450-lpmkkpzv.web.app (expires Sat, 08 Apr 2023 22:56:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
blindaa121
force-pushed
the
css-bem-classes
branch
2 times, most recently
from
a371883
to
769c356
Compare
blindaa121
force-pushed
the
css-bem-classes
branch
from
fe42f81
to
bda31c4
Compare
blindaa121
force-pushed
the
css-bem-classes
branch
from
1ad2ce1
to
aea8264
Compare
* Rename discriminator class * Avoid unnecessary outer div * Comment out deprecated/redundant styles and switch to toc border color for method-endpoint * Apply BEM convention to response status elements * Refactor response status styles
sserrata
reviewed
Mar 9, 2023
packages/docusaurus-theme-openapi-docs/src/theme/ApiDemoPanel/Curl/_Curl.scss
Outdated
Show resolved
Hide resolved
sserrata
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of the migration from CSS Modules to SCSS throughout our theme components, renaming classnames to follow BEM style convention, as well as introducing a manifest stylesheet and partial stylesheet per component for better organization. The end-goal of this approach is to provide our users with better customizability throughout our theme components and allow elements to be easily selected/targeted.
The following components that have migrated or pending migration:
ApiDemoPanelCodeTabsCurlFloatingButtonFormFileUploadFormItemFormMultiSelectFormSelectFormTextInputLiveEditorParamOptionsRequestServerApiTabsDiscriminatorTabsMimeTabsParamsItemResponseSamplesSchemaItemSchemaTabsMotivation and Context
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist