Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify tabs naming #612

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

Dr-Electron
Copy link
Contributor

Description

As mentioned in #611 , this is a minimal setup to unify the tabs. We could think about changing the var names and so on, but I wanted to wait for your approval first.

Motivation and Context

Mentioned in #611

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 401e649):

https://docusaurus-openapi-36b86--pr612-h25x0qz1.web.app

(expires Fri, 22 Sep 2023 15:40:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Dr-Electron
Copy link
Contributor Author

Found another place where it should be changed. Do you think we can merge this?

@sserrata sserrata merged commit c6e4e28 into PaloAltoNetworks:v2.0.0 Sep 11, 2023
7 of 8 checks passed
@welcome-to-palo-alto-networks

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

@Dr-Electron
Copy link
Contributor Author

Thanks ❤️

@Dr-Electron Dr-Electron deleted the unify-tab-naming branch September 13, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants