Reuse createAnyOneOf while creating a property
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
|
@Ugzuzg, thanks for opening the PR. Looks like there was a linter error that stopped the build from happening. |
Ugzuzg
force-pushed
the
fix/any-one-of
branch
from
ea67e0f
to
59a6b2a
Compare
|
@sserrata, reconfigured eslint to allow importing dev dependencies in test files. Hope, that's ok. |
Ugzuzg
force-pushed
the
fix/any-one-of
branch
from
59a6b2a
to
e056dc8
Compare
`createAnyOneOfProperty` has an incomplete implementation and doesn't display all possible types at the moment, but only 'object' type.
sserrata
force-pushed
the
fix/any-one-of
branch
from
e056dc8
to
79ca6c4
Compare
|
Visit the preview URL for this PR (updated for commit 79ca6c4): https://docusaurus-openapi-36b86--pr628-gy4p38hx.web.app (expires Thu, 16 Nov 2023 15:39:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Hi @Ugzuzg, I addressed the remaining linter error. The deploy preview looks good - how are things looking for you? |
|
Looks good. |
sserrata
approved these changes
Oct 17, 2023
|
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
createAnyOneOfPropertyhas an incomplete implementation and doesn't display all possible types at the moment, but only 'object' type. ReusingcreateAnyOneOfhelps with making it display all possible mods.Motivation and Context
A bug in
createAnyOneOfPropertyprevents from seeing all mods and showsMOD1,MOD2, etc for primitive types and arrays.How Has This Been Tested?
See the snapshot of the before and after:
55a2685
Screenshots (if appropriate)
Types of changes
Checklist