Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 18 and support Docusaurus >=2.4.1 <=2.4.3 #656

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

sserrata
Copy link
Member

@sserrata sserrata commented Nov 10, 2023

Description

Upgrades packages to support Docusaurus 2.4.3

Motivation and Context

In preparation for stable release and promotion of v2.0.0 branch to default.

How Has This Been Tested?

Tested with demo. See deploy preview for live test.

TODO:

Address the following warning observed in console. I suspect it could be caused by a third-party package as the OpenAPI theme does not implement the render method.

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more

Note that the warning does not appear in a production build

@sserrata sserrata added this to the v2.0 UI/UX Refresh milestone Nov 10, 2023
Copy link

Visit the preview URL for this PR (updated for commit 9dee524):

https://docusaurus-openapi-36b86--pr656-8b76bcyu.web.app

(expires Sun, 10 Dec 2023 15:26:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@sserrata sserrata self-assigned this Nov 10, 2023
@sserrata sserrata merged commit a5111bf into v2.0.0 Nov 10, 2023
12 checks passed
@sserrata sserrata deleted the v2/upgrade-react-18 branch November 10, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants