Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Callbacks Support to V3 #700

Conversation

lucasassisrosa
Copy link
Contributor

@lucasassisrosa lucasassisrosa commented Jan 18, 2024

Description

OpenAPI specs callbacks in endpoints were being ignored on rendering. I noticed the types were included but no code was found for rendering the callbacks. So callbacks included in Petstore cannot be seen at https://docusaurus-openapi.tryingpan.dev/petstore/subscribe-to-the-store-events

Motivation and Context

Be aligned with OpenAPI 3.0 Specs: https://swagger.io/docs/specification/callbacks/

How Has This Been Tested?

Go to petstore "Subscribe to the store events" - http://localhost:3000/petstore/subscribe-to-the-store-events

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

* add support to callbacks in openapi specs

* set package manager in package json

* implement operations as tabs within request panel

* render callbacks below Request and Responses

* remove unwanted files

* rename create file

* restore json settings
Copy link

github-actions bot commented Jan 18, 2024

Visit the preview URL for this PR (updated for commit af49550):

https://docusaurus-openapi-36b86--pr700-2yok7e9d.web.app

(expires Sat, 17 Feb 2024 16:11:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@sserrata sserrata merged commit 27fb9c0 into PaloAltoNetworks:v3.0.0 Jan 18, 2024
11 checks passed
@lucasassisrosa lucasassisrosa deleted the DOTCOM-2899-support-callbacks-v3 branch February 1, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants