-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Bug Fix] Firefox issue: Hide empty scrollbar track from Tab components #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +58 B (0%) Total Size: 6.34 MB
ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit ff64d18): https://docusaurus-openapi-36b86--pr785-knn5xy85.web.app (expires Fri, 26 Apr 2024 22:35:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
sserrata
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #272, where empty scroll bars for tab components are being rendered within Firefox browsers.
The
scrollbar-width: none
property has been added to the following classes:.openapi-tabs__response-list-container
.openapi-tabs__discriminator-list-container
.openapi-tabs__mime-list-container
.openapi-tabs__operation-list-container
.openapi-tabs__schema-list-container
Motivation and Context
The scrollbars should not be rendered if it is not necessary.
How Has This Been Tested?
Browser: Firefox
Tested locally by navigating to http://localhost:3000/petstore_versioned/add-pet and ensuring empty scroll bars are not being rendered.
Screenshots (if appropriate)
Types of changes
Checklist