-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Theme]: Fix @theme/Tabs namespace collision #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +13 B (0%) Total Size: 2.38 MB ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit f39b10b): https://docusaurus-openapi-36b86--pr84-qxr2sbur.web.app (expires Sat, 11 Jun 2022 21:03:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
sserrata
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See Issue #83
This PR consists of the following to remedy @theme/Tabs namespace collision between
docusaurus-theme-openapi-docs
anddocusaurus-theme-classic
Tabs
component toApiTabs
withindocusaurus-theme-openapi-docs
Tabs
component toApiTabs
withindocusaurus-plugin-openapi-docs
(markdown related operations)Motivation and Context
How Has This Been Tested?
ApiTabs
component was still intact when browsing through different OpenApi docs and did not introduce any breaking changes.@theme/Tabs
remained in its original styling (Testing purposes only, Tabs section is not included with the changes in this PR)Screenshots (if appropriate)
ApiTabs Component
Screen.Recording.2022-05-12.at.1.51.18.PM.mov
Tabs Component
Screen.Recording.2022-05-12.at.1.52.45.PM.mov
Types of changes
Checklist