-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Missing Info Object fields rendered undefined #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindaa121
changed the title
[Bug] Missing info fields rendered undefined
[Bug] Missing Info Object fields rendered undefined
May 21, 2022
Size Change: -9 B (0%) Total Size: 2.38 MB ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 6832a5e): https://docusaurus-openapi-36b86--pr98-wv6k3gez.web.app (expires Mon, 20 Jun 2022 00:39:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
sserrata
approved these changes
May 23, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #96
Added extra conditions and supplemental checks with
guard()
to safeguard againstundefined
within newly addedinfo
properties. The expected behavior is that anyinfo
field that isundefined
should not be written to*.info.mdx
files.Motivation and Context
How Has This Been Tested?
info
fields were not being rendered as expected)info
fields render accordingly)Screenshots (if appropriate)
Issue
Evidence
CSPM API
Petstore API
Types of changes
Checklist