Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iter_job_results() overrides credentials in get_job_results() #154

Closed
sserrata opened this issue Apr 13, 2020 · 0 comments · Fixed by #155
Closed

iter_job_results() overrides credentials in get_job_results() #154

sserrata opened this issue Apr 13, 2020 · 0 comments · Fixed by #155
Assignees
@sserrata
Labels
bug Something isn't working

Comments

@sserrata
Copy link
Member

Describe the bug

The QueryService iter_job_results() incorrectly overrides the request credentials value.

Expected behavior

Credentials should only be overridden at the request() level when explicitly passed.

Current behavior

Credentials are overridden by iter_job_results() even when they are not explicitly passed.

Possible solution

Refrain from passing credentials kwarg to underlying get_job_results() method unless they are explicitly passed to iter_job_results() method.

Steps to reproduce

Screenshots

Context

Your Environment

  • Version used: alpha10
  • Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3): python 3.7.7
  • Operating System and version (desktop or mobile): Mac OSX
  • Link to your project:
@sserrata sserrata added the bug Something isn't working label Apr 13, 2020
@sserrata sserrata self-assigned this Apr 13, 2020
sserrata added a commit to sserrata/pan-cortex-data-lake-python that referenced this issue Apr 13, 2020
@sserrata
Refrain from passing credentials kwarg to get_job_results() in iter_j…
daed19b 
…ob_results(), fixes PaloAltoNetworks#154
@sserrata sserrata mentioned this issue Apr 13, 2020
Merged
4 tasks
sserrata added a commit that referenced this issue Apr 13, 2020
@sserrata
Alpha11 (#155)
4125e8f 
* Check for credentials in instance instead of self.access_token_, fixes #153

* Refrain from passing credentials kwarg to get_job_results() in iter_job_results(), fixes #154

* Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sserrata sserrata

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alpha11 sserrata/pan-cortex-data-lake-python
1 participant
@sserrata