Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored how credentials are applied to requests to address bug #151. It was observed that
auto_refresh
was not being honored due to a regression bug introduced in #140 (see below).https://github.com/PaloAltoNetworks/pan-cortex-data-lake-python/pull/140/files#diff-0d2109dfe6920fb8c5b42a91db1c1ff2R223
The regression fix (#140) was intended to prevent authorization headers from being updated more than is necessary: once for when the
HTTPClient
object is created and another time each time therequest()
method is called. Instead, it was determined that credentials can and should only be applied at therequest()
layer. Furthermore, therequest()
kwarg forcredentials
was changed back to check for both method-level credentials and credentials passed via theHTTPClient
session.Motivation and Context
auto_refresh
is a key feature that was found to not be functioning as expectedHow Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist