Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha10 #152

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Alpha10 #152

merged 3 commits into from
Apr 13, 2020

Conversation

sserrata
Copy link
Member

@sserrata sserrata commented Apr 9, 2020

Description

Refactored how credentials are applied to requests to address bug #151. It was observed that auto_refresh was not being honored due to a regression bug introduced in #140 (see below).

https://github.com/PaloAltoNetworks/pan-cortex-data-lake-python/pull/140/files#diff-0d2109dfe6920fb8c5b42a91db1c1ff2R223

The regression fix (#140) was intended to prevent authorization headers from being updated more than is necessary: once for when the HTTPClient object is created and another time each time the request() method is called. Instead, it was determined that credentials can and should only be applied at the request() layer. Furthermore, the request() kwarg for credentials was changed back to check for both method-level credentials and credentials passed via the HTTPClient session.

Motivation and Context

  • auto_refresh is a key feature that was found to not be functioning as expected
  • Credentials should only be applied as often as needed and should be supported at the session and method levels.

How Has This Been Tested?

  • python test script

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sserrata sserrata merged commit 24056a7 into PaloAltoNetworks:master Apr 13, 2020
@sserrata sserrata deleted the alpha10 branch April 13, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant