Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-200 HTTP status in iter_job_results() #157

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

sserrata
Copy link
Member

Description

Allow non-200 responses in iter_job_results() method so that errors may be returned to client.

Motivation and Context

Error responses should be returned to client when using iter_job_results(). Currently, errors are masked due to the exception raised when a non-200 status is returned.

How Has This Been Tested?

Tested using scripts and CI/CD

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sserrata sserrata self-assigned this Apr 15, 2020
@sserrata sserrata merged commit ac51872 into PaloAltoNetworks:master Apr 15, 2020
@sserrata sserrata deleted the iter_job_results branch July 6, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant