Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): Fix logic on config locks + change funcs name for more obvious #113

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(client): Fix logic on config locks + change funcs name for more obvious #113

wants to merge 7 commits into from

Conversation

pimielowski
Copy link

@pimielowski pimielowski commented Nov 13, 2023 •
edited
Loading

Description

Fix logic choosing correct schema for PANOS versions

Motivation and Context

Name of the function was little confuse.
There was a issue with choosing correct schema based on the PANOS version

How Has This Been Tested?

go test -v ./... + using local code

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@pimielowski pimielowski changed the title (!fix/client)Fix logic on config locks + change funcs name for more obvious (fix/client)Fix logic on config locks + change funcs name for more obvious Nov 13, 2023
@pimielowski pimielowski changed the title (fix/client)Fix logic on config locks + change funcs name for more obvious (fix/client): Fix logic on config locks + change funcs name for more obvious Nov 13, 2023
@pimielowski pimielowski mentioned this pull request Nov 13, 2023
Open
4 tasks
@pimielowski pimielowski changed the title (fix/client): Fix logic on config locks + change funcs name for more obvious fix(client): Fix logic on config locks + change funcs name for more obvious Nov 14, 2023
sebastianczech
sebastianczech requested changes Nov 20, 2023
View reviewed changes
Copy link

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR duplication of #111 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianczech sebastianczech sebastianczech requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pimielowski @sebastianczech