Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Update main.tf #226

Closed
wants to merge 1 commit into from
Closed

Update main.tf #226

wants to merge 1 commit into from

Conversation

vinceneil666
Copy link

Since we are encoding the string - would we not also need to change the user_data to user_data_base64.

Description

Change the user_data to user_data_base64

Motivation and Context

Would we even need to bas64 encode it ? Or is this some legacy stuff ?

Since we are encoding the string - would we not also need to change the user_data to user_data_base64.
@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@migara
Copy link
Member

migara commented Sep 14, 2022

I believe this is not required since the provider will encode the string if you provide plain text string to user_data attribute
https://github.com/hashicorp/terraform-provider-aws/blob/d91573e08b8baa9ff04195fcc414cf81d8c34072/internal/service/ec2/ec2_instance.go#L1245

@pimielowski
Copy link
Contributor

@vinceneil666 we will close this issue since this change is not needed. If you feel otherwise let us now!

@pimielowski pimielowski closed this Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants