Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

docs(modules/subnet_set): Updated variable descriptions #231

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

michalbil
Copy link
Contributor

@michalbil michalbil commented Sep 22, 2022

Description

Add missing variable descriptions in subnet_set module.

Motivation and Context

Improve module documentation. Resolves #208 .

How Has This Been Tested?

Documentation changes only.

Types of changes

  • New feature (non-breaking change which adds functionality) - enhanced documentation

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@michalbil michalbil marked this pull request as ready for review September 28, 2022 12:17
Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good , I have only 1 comment for 1 variable

modules/subnet_set/variables.tf Outdated Show resolved Hide resolved
@michalbil michalbil force-pushed the subnetset-variable-descriptions branch from 01075c4 to fcc3825 Compare September 29, 2022 10:04
Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michalbil michalbil merged commit d90962e into develop Sep 29, 2022
@michalbil michalbil deleted the subnetset-variable-descriptions branch September 29, 2022 14:59
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

🎉 This PR is included in version 0.3.0 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved subnet_set documentation
3 participants