Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat: bump up minimum Terraform version to 1.0.0 #253

Merged
merged 7 commits into from
Jan 26, 2023
Merged

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Dec 22, 2022

Description

Setting minimum supported Terraform version to 1.0.0.

Motivation and Context

PR closes #246.

How Has This Been Tested?

Code was tested on local machine using Terratest tests/examples/examples_test.go as described in tests/examples/README.md.

Screenshots (if appropriate)

Not appropriate

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech marked this pull request as ready for review December 22, 2022 07:41
@sebastianczech sebastianczech requested a review from a team as a code owner December 22, 2022 07:41
Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good job! 💯 , I just think about separate testing part from this PR

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 12, 2023

Overall good job! 💯 , I just think about separate testing part from this PR

@pimielowski , thank you for review :)
Regarding separating testing part - should I remove tests/examples folder , which I used for testing examples ? Or maybe leave it for now and when we start writing tests for examples, we will move into proper place ?

Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sebastianczech. Please remove the tests dir before merging this PR.

@sebastianczech sebastianczech merged commit 02a342c into main Jan 26, 2023
@sebastianczech sebastianczech deleted the tf-min-1-0 branch January 26, 2023 08:47
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.4.2 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Q3 FY23 - Feb-Apr
Development

Successfully merging this pull request may close these issues.

Bump up minimum Terraform version to 1.0
3 participants