Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

test: Use ResourceChangesMap to check planned changes, do not use regexp #278

Merged

Conversation

sebastianczech
Copy link
Contributor

Description

Small improvements in checking, if after deployment and running Terraform plan there are planned changes. If yes, then our infrastructure code is not idempotent and test is going to detect such case.

Motivation and Context

It's a part of #86

How Has This Been Tested?

It was tested using Terratest.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech marked this pull request as ready for review January 19, 2023 12:28
@sebastianczech sebastianczech requested a review from a team as a code owner January 19, 2023 12:28
Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/internal/testskeleton/testskeleton.go Show resolved Hide resolved
@sebastianczech sebastianczech merged commit a3034d9 into test-skeleton-165 Jan 19, 2023
@sebastianczech sebastianczech deleted the improve-checking-changes-after-deployment branch January 19, 2023 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants