Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MAJOR): Major refactor of all modules and examples #37

Merged
merged 55 commits into from Apr 25, 2024
Merged

feat(MAJOR): Major refactor of all modules and examples #37

merged 55 commits into from Apr 25, 2024

Conversation

acelebanski
Copy link
Contributor

@acelebanski acelebanski commented Apr 5, 2024 •
edited

Description

This PR introduces v3.0 of the repo and contains:

  • major refactor to all modules (except for legacy virtual_machine module)
  • replacement of application_insights module with a new ngfw_metrics module
  • introduction of test_infrastructure module
  • significant refactor to all reference architecture examples
  • bump of required Terraform version to 1.5
  • bump of required AzureRM provider version to 3.98

Details are described in the issues mentioned in the section below.

Motivation and Context

Big part of the work has been done on the old archived repo, issue here:
PaloAltoNetworks/terraform-azurerm-vmseries-modules#307

Work has been finished on the new repo and documented in this issue:
#3

How Has This Been Tested?

All modules were thoroughly tested "on the go". At the end, all examples were manually tested end-to-end.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

FoSix and others added 30 commits September 26, 2023 16:41
@FoSix
name property
574e56f
@FoSix
working vnet example
c3ac63f
@FoSix
update documentation
bb242f5
@FoSix
1st module tests
2b2c82f
@FoSix
move tests to a separate branch
60f8c07
@FoSix
Merge branch 'main' into 307-refactor-modules
44c45fb
@FoSix
refactor(module/vnet): module refactor + adjusted examples (#338)
fe1d399
@FoSix
Merge remote-tracking branch 'origin/main' into 307-refactor-modules
16eab69
@FoSix
Merge branch 'main' into 307-refactor-modules
d1fcd31
@FoSix
refactor(module/vnet): documentation update and validation fixes (#351)
5601617
@acelebanski @FoSix
refactor(module/vnet_peering)!: module refactor and adjusted examples…
60ba789 
… (#355)

Co-authored-by: Łukasz Pawlęga <42772730+FoSix@users.noreply.github.com>
@sebastianczech
refactor(module/virtual_network_gateway): Refactor module for VNG (#339)
b97a5b0
@acelebanski
refactor: vnet tfvars in examples (#359)
bcf1c63
@FoSix
refactor(module/loadbalancer): including examples (#348)
a63213f
@FoSix
refactor: add support for disable bgp route propagation (#367)
4ded3dd
@acelebanski
refactor(module/natgw)!: module refactor and adjusted examples (#358)
d877740
@sebastianczech
refactor(module/appgw): Refactor module Application Gateway and adjus…
f24fbea 
…t examples (#345)
@FoSix
Merge branch 'main' into 307-refactor-modules
88ffcc2
@FoSix
refactor: vmss + application insights (#360)
7e8b486
@acelebanski
refactor(module/panorama)!: module refactor and adjusted examples (#373)
549633b 
As discussed with @FoSix
@FoSix
refactor: bootstrap and vmseries (#371)
ad1c4d7
@sebastianczech
refactor(module/gwlb): Refactor Gateway Load Balancer module (#372)
5e8e266
@sebastianczech
refactor(example/gwlb_with_vmseries): Refactor Gateway Load Balancer …
19d7e93 
…example (#4)
@FoSix @acelebanski @alperenkose
refactor: common config variable (#6)
36ddea5 
Co-authored-by: Adrian Celebanski <acelebanski@paloaltonetworks.com>
Co-authored-by: Adrian Celebanski <135693994+acelebanski@users.noreply.github.com>
Co-authored-by: Alp Eren Kose <alperenkose@gmail.com>
@sebastianczech
chore: Add comments with links to TF Registry documentation to all re…
7beb04b 
…sources (#20)
@acelebanski
Merge branch 'main' into refactor-modules
21d4224
@acelebanski
Fix GO files for appgw & vng examples
d8df2b8
@sebastianczech
chore: Upgrade Terraform version for examples, fix links for diagrams…
18545ec 
… and sources for modules (#23)
@acelebanski
refactor: code style unification (#24)
4d388b0
@sebastianczech
feat: Rename location to region, fix issues with VNG (#26)
b01cf56
@acelebanski
Copy link
Contributor Author

acelebanski commented Apr 5, 2024 •
edited by github-actions bot

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6 1.7"

Testing job ID: 8576222000
Job result: FAILURE

@acelebanski
Copy link
Contributor Author

acelebanski commented Apr 6, 2024 •
edited by github-actions bot

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6 1.7"

Testing job ID: 8580780556
Job result: SUCCESS

acelebanski and others added 12 commits April 12, 2024 16:10
@acelebanski
Copy link
Contributor Author

acelebanski commented Apr 21, 2024 •
edited by github-actions bot

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6 1.7"

Testing job ID: 8776348247
Job result: FAILURE

@acelebanski
Copy link
Contributor Author

acelebanski commented Apr 22, 2024 •
edited by github-actions bot

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6 1.7"

Testing job ID: 8784953319
Job result: SUCCESS

@acelebanski acelebanski marked this pull request as ready for review April 25, 2024 09:30
@acelebanski acelebanski requested a review from a team as a code owner April 25, 2024 09:30
michalbil
michalbil approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@michalbil michalbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@acelebanski acelebanski merged commit 4a68e10 into main Apr 25, 2024
101 checks passed
@acelebanski acelebanski deleted the refactor-modules branch April 25, 2024 10:47
This was referenced Apr 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperenkose alperenkose alperenkose left review comments

@michalbil michalbil michalbil approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request refactor Related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor modules
5 participants
@acelebanski @alperenkose @michalbil @FoSix @sebastianczech