Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rename location to region, fix issues with VNG #26

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat: Rename location to region, fix issues with VNG #26

merged 2 commits into from
Mar 12, 2024

Conversation

sebastianczech
Copy link
Contributor

Description

PR delivers

  • changed name of variable location to region (in all examples and modules)
  • fix issues with VNG validation and instance settings type

Motivation and Context

#25

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech requested a review from a team as a code owner March 12, 2024 08:06
acelebanski
acelebanski approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@acelebanski acelebanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sebastianczech sebastianczech merged commit b01cf56 into refactor-modules Mar 12, 2024
1 check passed
@sebastianczech sebastianczech deleted the rename-location-to-region branch March 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelebanski acelebanski acelebanski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebastianczech @acelebanski