Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

refactor(module/gwlb): Refactor Gateway Load Balancer module #372

Merged
merged 27 commits into from
Jan 23, 2024
Merged

refactor(module/gwlb): Refactor Gateway Load Balancer module #372

merged 27 commits into from
Jan 23, 2024

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Dec 20, 2023 •
edited
Loading

Description

PR delivers changes for Gateway Load Balancer module.
New example with code similar to e.g. common VM-Series example, will be prepare in new PR.

Motivation and Context

#328

How Has This Been Tested?

Code was tested by deploying gwlb_with_vmseries example, which is going to be delivered in new PR.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech changed the title feat(module/gwlb): Refactor Gateway Load Balancer module with example refactor(module/gwlb): Refactor Gateway Load Balancer module with example Dec 20, 2023
@sebastianczech sebastianczech changed the base branch from main to 307-refactor-modules December 20, 2023 14:31
@sebastianczech sebastianczech marked this pull request as ready for review December 21, 2023 08:36
@sebastianczech sebastianczech requested a review from a team as a code owner December 21, 2023 08:36
acelebanski
acelebanski suggested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@acelebanski acelebanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the module code, example to be discussed on call once you're back.

modules/gwlb/variables.tf Show resolved Hide resolved
modules/gwlb/variables.tf Outdated Show resolved Hide resolved
modules/gwlb/variables.tf Outdated Show resolved Hide resolved
modules/gwlb/variables.tf Outdated Show resolved Hide resolved
modules/gwlb/variables.tf Outdated Show resolved Hide resolved
modules/gwlb/variables.tf Show resolved Hide resolved
modules/gwlb/main.tf Outdated Show resolved Hide resolved
modules/gwlb/main.tf Outdated Show resolved Hide resolved
examples/gwlb_with_vmseries/variables.tf Outdated Show resolved Hide resolved
examples/gwlb_with_vmseries/example.tfvars Outdated Show resolved Hide resolved
FoSix
FoSix suggested changes Jan 22, 2024
View reviewed changes
examples/gwlb_with_vmseries/.header.md Outdated Show resolved Hide resolved
examples/gwlb_with_vmseries/.header.md Outdated Show resolved Hide resolved
examples/gwlb_with_vmseries/variables.tf Outdated Show resolved Hide resolved
examples/gwlb_with_vmseries/variables.tf Outdated Show resolved Hide resolved
examples/gwlb_with_vmseries/versions.tf Outdated Show resolved Hide resolved
modules/gwlb/variables.tf Outdated Show resolved Hide resolved
modules/gwlb/variables.tf Show resolved Hide resolved
modules/gwlb/variables.tf Outdated Show resolved Hide resolved
modules/gwlb/variables.tf Show resolved Hide resolved
modules/gwlb/versions.tf Outdated Show resolved Hide resolved
@sebastianczech sebastianczech changed the title refactor(module/gwlb): Refactor Gateway Load Balancer module with example refactor(module/gwlb): Refactor Gateway Load Balancer module Jan 23, 2024
@sebastianczech sebastianczech merged commit 5e8e266 into 307-refactor-modules Jan 23, 2024
2 checks passed
@sebastianczech sebastianczech deleted the 328-refactor-gwlb branch January 23, 2024 13:02
@sebastianczech sebastianczech mentioned this pull request Jan 23, 2024
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acelebanski acelebanski acelebanski requested changes

@FoSix FoSix FoSix requested changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebastianczech @FoSix @acelebanski