Added capability to put login banner using general_settings #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
|
Hi @shinmog! Just wanted to see if you had a chance to look at this PR. I have more coming to add more features, but wanted to see I am following your structure with this small PR. lmk if you have any suggestions! |
|
@jinfluenza Rebase when you get a chance and I can merge this enhancement |
|
@shinmog it has been rebased. thank you! |
|
I'm also interested in this merge request. Can it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add capability to put login banner using general settings resource block
Motivation and Context
As we try to automate further, I feel that a lot of consumer will benefit from having an ability to add login banner programmatically. While making this change I noticed that Pango already has login banner in its config, so I just needed to enable login banner within provider code base.
How Has This Been Tested?
This was tested via Panos environment
Before the change
Adding the login banner in the resource block
Able to read the changes that are being made
After applying and running the firewall-commit binary
This was tested on VM-series of Pan OS deployed in Cloud and applying the changes using the Terraform to the instance.
Types of changes
Checklist