Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug parsing DELIMITER ;; #40

Merged
merged 3 commits into from Feb 9, 2021
Merged

Conversation

sasadjolic
Copy link
Contributor

Fixes #39

@coveralls
Copy link

coveralls commented Feb 6, 2021

Pull Request Test Coverage Report for Build 120

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 98.944%

Totals Coverage Status
Change from base Build 117: 0.02%
Covered Lines: 196
Relevant Lines: 196

💛 - Coveralls

…starting tests and then revert it to it's original state before closing connection, to ensure that test will pass in all environments.
@Pamblam
Copy link
Owner

Pamblam commented Feb 9, 2021

Thank you so much @sasadjolic! That looks great, and thanks for adding the test as well.

My local MariaDB install came with log_bin_trust_function_creators set to Off, so the tests didn't pass initially. I just added some code to check that variable when connecting and reset it to it's initial value when disconnecting.

As long as the Travis build come back clean I'll merge it here in a minute.

@Pamblam Pamblam merged commit 9627ea2 into Pamblam:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DELIMITER keyword not supported?
3 participants