-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frozen] pyDKB.dataflow.stage tests #196
base: pyDKB
Are you sure you want to change the base?
Commits on Nov 16, 2018
-
5
Configuration menu - View commit details
-
Copy full SHA for 4c1c44a - Browse repository at this point
Copy the full SHA 4c1c44aView commit details
Commits on Nov 19, 2018
-
Now the name of an argument that causes assertion failure should be obtainable.
2Configuration menu - View commit details
-
Copy full SHA for e1343c5 - Browse repository at this point
Copy the full SHA e1343c5View commit details -
This includes mode dictionary creation, removal of 'mode' member from args_to_add dictionary and repositioning of the latter for the sake of consistency.
3Configuration menu - View commit details
-
Copy full SHA for 1022253 - Browse repository at this point
Copy the full SHA 1022253View commit details -
14
Configuration menu - View commit details
-
Copy full SHA for 088e180 - Browse repository at this point
Copy the full SHA 088e180View commit details
Commits on Nov 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 339c3ca - Browse repository at this point
Copy the full SHA 339c3caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a56cd0 - Browse repository at this point
Copy the full SHA 1a56cd0View commit details -
This way the code should be more flexible and easier to read.
Configuration menu - View commit details
-
Copy full SHA for dcbdeab - Browse repository at this point
Copy the full SHA dcbdeabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eaa413 - Browse repository at this point
Copy the full SHA 3eaa413View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1565684 - Browse repository at this point
Copy the full SHA 1565684View commit details -
Configuration menu - View commit details
-
Copy full SHA for be922c9 - Browse repository at this point
Copy the full SHA be922c9View commit details -
Removed short version of override tests.
Both short and long versions of defining an argument are doing the same thing and are processed by argparse. Therefore, it is presumed that testing both versions of defining each argument is enough and overriding tests can be done just for one version.
Configuration menu - View commit details
-
Copy full SHA for aa90f7c - Browse repository at this point
Copy the full SHA aa90f7cView commit details -
Moved override_hdfs_mode definition into a loop.
Note: new version includes mode args check that was missing.
Configuration menu - View commit details
-
Copy full SHA for cf56b0c - Browse repository at this point
Copy the full SHA cf56b0cView commit details
Commits on Nov 21, 2018
-
Improved readability in testing hdfs overrides.
In current version the line of code is pointless because arg is either 'source' or 'dest' which are redefined in the next few lines. However, the code reader may not know that. Furthermore, this line may be of use if it would be necessary to test some other arguments' interaction with hdfs.
Configuration menu - View commit details
-
Copy full SHA for 8a37c7d - Browse repository at this point
Copy the full SHA 8a37c7dView commit details
Commits on Nov 23, 2018
-
Moved repeating args definition into setUp().
tearDown() and check_args() were modified to accomodate the changes.
1Configuration menu - View commit details
-
Copy full SHA for 324978c - Browse repository at this point
Copy the full SHA 324978cView commit details
Commits on Dec 14, 2018
-
Added tests for config argument.
The argument differs from the others because its type is not string - therefore, argparse performs some manipulations with the supplied file, and these manipulations have to be taken into consideration.
8Configuration menu - View commit details
-
Copy full SHA for fdb498a - Browse repository at this point
Copy the full SHA fdb498aView commit details
Commits on Dec 17, 2018
-
Argparse module throws SystemExit when something is wrong with the supplied arguments, regardless of the problem's type. Implemented a function to intercept such behaviour and retrieve argparse' message. Analysis of the message is used to check that the encountered problem is the expected one.
Configuration menu - View commit details
-
Copy full SHA for 42877e2 - Browse repository at this point
Copy the full SHA 42877e2View commit details
Commits on Jan 23, 2019
-
Added 'incorrect' tests for mode, source and dest.
These arguments have a fixed sets of allowed values. The tests are checking that the code correctly displays error information when an unexpected argument value is supplied.
Configuration menu - View commit details
-
Copy full SHA for 9dc9aa0 - Browse repository at this point
Copy the full SHA 9dc9aa0View commit details -
Improved the functions with 'short' argument.
The functions now perform 'short'-related manipulations by defining varialbes and using them in functions instead of having two different calls of the same function.
Configuration menu - View commit details
-
Copy full SHA for 19ca409 - Browse repository at this point
Copy the full SHA 19ca409View commit details -
Updated tests for correct config.
Now the tests check that the parameter in question is a file, rather than not None.
Configuration menu - View commit details
-
Copy full SHA for c3e4810 - Browse repository at this point
Copy the full SHA c3e4810View commit details
Commits on Apr 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c81a096 - Browse repository at this point
Copy the full SHA c81a096View commit details
Commits on Apr 26, 2019
-
- Replace stage.parse_args() with stage.configure(). - Update tests to set input_dir if source is either stream or hdfs. - Add an input file name into most tests - 'file' is now a default source, and it demands an input file. Exceptions: test_i/test_input_dir - all files in the input dir will be taken, so input file is not mandatory; all tests including --hdfs; test_default - its role is to simulate an execution with no command line arguments. - Change test_default() to catch the error about missing input file. - Change add_override_mode() - file source/destination is not allowed in map-reduce mode, meaning that such combination raises an error that must be caught. - Define stage.configure() arguments in list args in some tests to follow the 80 symbols line length restriction without stretching a single code line into 3+ lines.
Configuration menu - View commit details
-
Copy full SHA for f795e24 - Browse repository at this point
Copy the full SHA f795e24View commit details
Commits on Apr 29, 2019
-
If EOM is set to empty string, EOP will be set to '\n', unless overridden.
Configuration menu - View commit details
-
Copy full SHA for 77ef71b - Browse repository at this point
Copy the full SHA 77ef71bView commit details -
Change value used to trigger an error.
It is possible that value 'i' will become valid in the future, while 'incorrect' is much 'safer' in this regard - all of the values are single letters.
Configuration menu - View commit details
-
Copy full SHA for 1d4feb2 - Browse repository at this point
Copy the full SHA 1d4feb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5d6842 - Browse repository at this point
Copy the full SHA b5d6842View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38a383e - Browse repository at this point
Copy the full SHA 38a383eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c99f4c6 - Browse repository at this point
Copy the full SHA c99f4c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1df893 - Browse repository at this point
Copy the full SHA e1df893View commit details
Commits on Apr 30, 2019
-
Divide test_ProcessorStage.py per how-to: tests.
- Move common function to separate file lib.py.
Configuration menu - View commit details
-
Copy full SHA for 7dad261 - Browse repository at this point
Copy the full SHA 7dad261View commit details